From owner-cvs-all@FreeBSD.ORG Wed Dec 13 05:24:13 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 25EF416A415 for ; Wed, 13 Dec 2006 05:24:13 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id A490943CA2 for ; Wed, 13 Dec 2006 05:22:45 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kBD5MIUM022912; Tue, 12 Dec 2006 22:22:19 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 12 Dec 2006 22:23:17 -0700 (MST) Message-Id: <20061212.222317.1021576677.imp@bsdimp.com> To: rizzo@icir.org From: "M. Warner Losh" In-Reply-To: <20061212203002.A51749@xorpc.icir.org> References: <20061212.140133.1649770385.imp@bsdimp.com> <20061212.211323.-1573945956.imp@bsdimp.com> <20061212203002.A51749@xorpc.icir.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Tue, 12 Dec 2006 22:22:19 -0700 (MST) Cc: gurney_j@resnet.uoregon.edu, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, luigi@FreeBSD.org, cvs-all@FreeBSD.org, ticso@cicely.de Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2006 05:24:13 -0000 In message: <20061212203002.A51749@xorpc.icir.org> Luigi Rizzo writes: : On Tue, Dec 12, 2006 at 09:13:23PM -0700, M. Warner Losh wrote: : > In message: <20061212.140133.1649770385.imp@bsdimp.com> : ... : > : while established practice in NetBSD, met with considerable : > : controversy when I tried to expand it in FreeBSD land. However, : > : putting things in param.h met with no resistance whatsoever and was : > : actively suggested. Maybe we should move this straggler from _types.h : > : to param.h and start using it more often. : > : : > : Warner : > : : > : > Here's what I came up with this afternoon between fires at work. : > : > Comments? : : makes sense - there are probably more places where it should : be used (judging by the output of "grep -r __sparc64__ sys/") Yes. I was going to do a complete audit, but wanted to get the basic concepts signed off on first. : just to make sure - are we guaranteed that param.h is included : by every kernel file, or there is the risk that someone forgets : it thus missing the #define __NO_STRICT_ALIGNMENT ? I believe that we are... The result of the discussion last time was that's a pretty safe bet. Warner