From owner-svn-src-projects@FreeBSD.ORG Mon Jun 7 01:49:25 2010 Return-Path: Delivered-To: svn-src-projects@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A1D2106564A; Mon, 7 Jun 2010 01:49:25 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 3A9A18FC0C; Mon, 7 Jun 2010 01:49:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o571iMON099663; Sun, 6 Jun 2010 19:44:22 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 06 Jun 2010 19:44:30 -0600 (MDT) Message-Id: <20100606.194430.242248466057854597.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: References: <516EEDC6-069A-4780-84DF-BBFF43ABCDE5@samsco.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-projects@FreeBSD.org, xcllnt@mac.com, nwhitehorn@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r208850 - projects/ppc64/sys/powerpc/include X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 01:49:25 -0000 In message: Scott Long writes: : On the specific topic of BUS_SPACE_UNRESTRICTED, that's a definition : that seems to have been "borrowed" from the bus_space API. Maybe at : one time there was a desire to marry bus_space (bus.h) and bus_dma : together in some fashion, but I don't see that having any practical : value now. bus_dma.h and bus.h are separate interfaces and : shouldn't be sharing definitions, as far as I'm concerned. If there : are any disagreements on this, I'm happy to hear them. busdma started out life as being dependent on bus_space. Today, it still depends on bus_addr_t and bus_size_t, etc. BUS_SPACE_UNRESTRICTED appears to have only ever been used by bus_dma, and never by bus_space itself. In fact, the whole family of BUS_SPACE_MAX{SIZE,ADDR}_{24,32}BIT appear to be MI as well. And BUS_SPACE_MAXSIZE is defined wrong for at least amd64.... Warner