From nobody Fri Jan 2 20:52:31 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4djbVR6htwz6MFL6 for ; Fri, 02 Jan 2026 20:52:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4djbVR0zRFz3rBN for ; Fri, 02 Jan 2026 20:52:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767387151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AEvhvTk1/0uYL8lR5VZkkgsHjmptooRK877nhjCl8k8=; b=mIpAESjJM1nTHY71mTCPyiPb18L8rz56ZZ2CB+k/pdsFE3OJmhtaQna24AGg5phwU3jiiR +9kVHOMMDHMTrE/JoEcNJ/dY86FTuNW5ytjfgS3kd85r8OgNL00TH1iTLSu9ToepLCsAgp m+T4OzOg/mKGhoRpOcBMelJyTvACEK3imZ8SM1NjNlcxPFxQjOKi+vnpW+3adx9xOWpw0X Bl7cLwkG+NTwVC9UKQo/DMT48halW2bmzEgDK3GcC6N3t/yilSpGBeSD53h3LlRthseeiU t6awMpFzgeh6zDo1JRQxUkgfcWziG++yosAgQxoLnSYOHKTG5XLVVmujUKmZyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767387151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AEvhvTk1/0uYL8lR5VZkkgsHjmptooRK877nhjCl8k8=; b=oGl7lZS4tptmT+SHcOuSe8zgLLaFrHaDe6C/nX83gyQgiPggM7WZPZjjgKZiURgQJ89ZJT ePM+thyvyc2CCdldpvD6qltkXxKGn8XN9gvE1+dT7PFm1Oz1v8iKvX+of/xqatfB1gzvZ8 K+c4CWQrkiBUj5/B+6vcLIyxAQGRFS/4BBXTTEaVAYLOO7LCuO/VgvEsk3DWBljcRlRFso +Qp34Nn/AtQixSldLz1sqtTw9AjvgR03FCQ2Ghsj5DADiQl0cjw3RiD17PjnmwDDo4I69B +HysX/2uyT7qjffCgaTPjmBshWQRZRVn58GWGrEw10Nrs3H66uAUOeYav9pnGA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767387151; a=rsa-sha256; cv=none; b=vrg36zwe26Ss3AUBw5AWF8bgOaPXdG0FGbritbS8en0FFA4XJC7K8RcEl32jKdurQmbV8j 8nrSA3OCPdl7tvUZ8ktdKbArIugE23ecdnIL/EVaGjqFrYlR2KlsDk7hj1ZmLD23DWTgUC ACwH80iBzid3m6TFJKdlNydTNlGHl/3WwIPh8ECLHisWVjwyBYC8hE8YjKV1aR14Jiuu+z V6T83cpRj+v2x2I86E7V6CKsoRKtxA7auPzVutmnS3od1hIK5XQyC5+Fj07pKYLyb+bXbU KLhMmF+gP2utvKFpOwWbAsXE58LkRovAe+sQlT8WAlphOEZqjlRQYN15ahvlmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4djbVR0GrczbHY for ; Fri, 02 Jan 2026 20:52:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id a2e5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Jan 2026 20:52:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Kyle Evans From: Dimitry Andric Subject: git: 958f2ab6d400 - stable/13 - compat: linux: use appropriate variables for copying out old timers List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 958f2ab6d400de5a8990c392d17eecaf2e47e6c4 Auto-Submitted: auto-generated Date: Fri, 02 Jan 2026 20:52:31 +0000 Message-Id: <6958300f.a2e5.7c747a5d@gitrepo.freebsd.org> The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=958f2ab6d400de5a8990c392d17eecaf2e47e6c4 commit 958f2ab6d400de5a8990c392d17eecaf2e47e6c4 Author: Kyle Evans AuthorDate: 2025-12-28 22:02:04 +0000 Commit: Dimitry Andric CommitDate: 2026-01-02 20:49:59 +0000 compat: linux: use appropriate variables for copying out old timers We copyout &l_oval but do the conversions into &l_val, leaving us with stack garbage. A build with an LLVM21 cross-toolchain seems to catch this. Reported by: Florian Limberger Reviewed by: markj Fixes: a1fd2911ddb06 ("linux(4): Implement timer_settime64 syscall.") MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52985 (cherry picked from commit 541a98d7e28a8e4697ac2fa78dd4c4203c2c3a9c) --- sys/compat/linux/linux_timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linux/linux_timer.c b/sys/compat/linux/linux_timer.c index bfa17d7e8aa5..632c4c530eec 100644 --- a/sys/compat/linux/linux_timer.c +++ b/sys/compat/linux/linux_timer.c @@ -131,7 +131,7 @@ linux_timer_settime(struct thread *td, struct linux_timer_settime_args *uap) return (error); error = kern_ktimer_settime(td, uap->timerid, flags, &val, ovalp); if (error == 0 && uap->old != NULL) { - error = native_to_linux_itimerspec(&l_val, &val); + error = native_to_linux_itimerspec(&l_oval, &oval); if (error == 0) error = copyout(&l_oval, uap->old, sizeof(l_oval)); } @@ -158,7 +158,7 @@ linux_timer_settime64(struct thread *td, struct linux_timer_settime64_args *uap) return (error); error = kern_ktimer_settime(td, uap->timerid, flags, &val, ovalp); if (error == 0 && uap->old != NULL) { - error = native_to_linux_itimerspec64(&l_val, &val); + error = native_to_linux_itimerspec64(&l_oval, &oval); if (error == 0) error = copyout(&l_oval, uap->old, sizeof(l_oval)); }