From owner-freebsd-current  Wed Jan 27 22:51:13 1999
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id WAA24370
          for freebsd-current-outgoing; Wed, 27 Jan 1999 22:51:13 -0800 (PST)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from whistle.com (s205m131.whistle.com [207.76.205.131])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA24364
          for <current@FreeBSD.ORG>; Wed, 27 Jan 1999 22:51:12 -0800 (PST)
          (envelope-from archie@whistle.com)
Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id WAA29227; Wed, 27 Jan 1999 22:50:40 -0800 (PST)
Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0)
	id xma029225; Wed, 27 Jan 99 22:50:23 -0800
Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id WAA24262; Wed, 27 Jan 1999 22:50:23 -0800 (PST)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199901280650.WAA24262@bubba.whistle.com>
Subject: Re: btokup() macro in sys/malloc.h
In-Reply-To: <199901280540.WAA26288@mt.sri.com> from Nate Williams at "Jan 27, 99 10:40:16 pm"
To: nate@mt.sri.com (Nate Williams)
Date: Wed, 27 Jan 1999 22:50:23 -0800 (PST)
Cc: current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL38 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Nate Williams writes:
> > In fact, style(9) should say:
> > 
> >   If at all possible, your code should compile without warnings
> >   when the gcc -Wall flag is given.
> 
> I disagree.  As has been shown many times in the past (and I suspect the
> down-under constituent will show that at least a couple of the
> 'warnings' fixes will be wrong and hide bogus code), making -Wall a goal
> causes people to cover up bad code with bad casts and such.
> 
> '-Wall' is *NOT* a good design goal.

Well, I respectfully disagree with that. If you're "fixing" warnings
by hiding them, then the problem is with the programmer, not the
compiler.

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message