From owner-p4-projects@FreeBSD.ORG Tue Jan 2 18:01:44 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 86D4016A407; Tue, 2 Jan 2007 18:01:44 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4A6E216A412 for ; Tue, 2 Jan 2007 18:01:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id E97ED13C455 for ; Tue, 2 Jan 2007 18:01:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l02I1a65012660; Tue, 2 Jan 2007 13:01:36 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Olivier Houchard Date: Tue, 2 Jan 2007 13:01:26 -0500 User-Agent: KMail/1.9.4 References: <200701021653.l02GrTiC007919@repoman.freebsd.org> <200701021220.09987.jhb@freebsd.org> <20070102174011.GA93081@ci0.org> In-Reply-To: <20070102174011.GA93081@ci0.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701021301.26644.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Tue, 02 Jan 2007 13:01:36 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2406/Tue Jan 2 06:58:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 112424 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jan 2007 18:01:44 -0000 On Tuesday 02 January 2007 12:40, Olivier Houchard wrote: > On Tue, Jan 02, 2007 at 12:20:09PM -0500, John Baldwin wrote: > > On Tuesday 02 January 2007 11:53, Olivier Houchard wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=112424 > > > > > > Change 112424 by cognet@hulglah on 2007/01/02 16:52:32 > > > > > > Implement a minimalist intr_eoi_src which just calls arm_unmask_irq(), > > > so that irq are unmasked after a filter+ithread runs. > > > > Err, you shouldn't need to mask the IRQ unless you schedule the ithread. Hmm, > > I'd also prefer it if we didn't pass function handlers to mi_handle_intr() (which > > should be intr_handle() or something, all the MI interrupt code is intr_foo(), > > not mi_foo_intr()) but instead set them in the intr_event and passed them to > > intr_event_create(). > > Basically the problem is arm_execute_handlers() can't know if we're talking > about an interrupt for which we had a filter, and so we don't have to mask it, > or an interrupt for which we have to schedule the ithread. So it has to be > always masked. Err, no, it shouldn't. :) mi_handle_intr() will use a different callback for the different cases. It should call the disable_and_eoi() hook if the interrupt should be masked, and it should just call teh eoi() hook if the interrupt just needs to be eoi'd but not disabled (because a filter claimed it). -- John Baldwin