From owner-svn-src-all@FreeBSD.ORG Sat Dec 15 07:05:14 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B09ECB22; Sat, 15 Dec 2012 07:05:14 +0000 (UTC) (envelope-from rpaulo@felyko.com) Received: from felyko.com (felyko.com [IPv6:2607:f2f8:a528::3:1337:ca7]) by mx1.freebsd.org (Postfix) with ESMTP id 7B4F78FC15; Sat, 15 Dec 2012 07:05:14 +0000 (UTC) Received: from [IPv6:2601:9:4d00:85:5d89:5f66:6445:4383] (unknown [IPv6:2601:9:4d00:85:5d89:5f66:6445:4383]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by felyko.com (Postfix) with ESMTPSA id BD8913981E; Fri, 14 Dec 2012 23:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=felyko.com; s=mail; t=1355555114; bh=OfkUvTb1inY76Yf8Rzr75bjDrQijg+aMe/1RcY1mFYo=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=dbmdvrXhCvY1BNDSWVAYgVwlxri8lwVwLaU4B0RarNpxbWhkSAcwNy80FSdWJK0H5 hP9gqeSXfzsVXyd3AUHrL8bdZ3VKRAJnVnuQ8AxgEmavOzgs88p9jUtb824rlBC9QV ZBA3AxHlOHxRFwwSPae6jACBU0JFupDgvd4AwN/o= Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: svn commit: r244105 - in head/sys: kern sys From: Rui Paulo In-Reply-To: <201212121042.51362.jhb@freebsd.org> Date: Fri, 14 Dec 2012 23:05:12 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201212110123.qBB1NpOV060501@svn.freebsd.org> <201212121042.51362.jhb@freebsd.org> To: Alfred Perlstein X-Mailer: Apple Mail (2.1499) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2012 07:05:14 -0000 On 12 Dec 2012, at 07:42, John Baldwin wrote: > On Monday, December 10, 2012 8:23:51 pm Alfred Perlstein wrote: >> Author: alfred >> Date: Tue Dec 11 01:23:50 2012 >> New Revision: 244105 >> URL: http://svnweb.freebsd.org/changeset/base/244105 >>=20 >> Log: >> Switch the hardwired WITNESS panics to kassert_panic. >>=20 >> This is an ongoing effort to provide runtime debug information >> useful in the field that does not panic existing installations. >>=20 >> This gives us the flexibility needed when shipping images to a >> potentially large audience with WITNESS enabled without worrying >> about formerly non-fatal LORs hurting a release. >>=20 >> Sponsored by: iXsystems >=20 > Witness doesn't panic on LORs. These are all bigger violations for = things=20 > like doing sx_sunlock() on a exclusively locked sx lock. That is not = safe and=20 > is merely going to result in data corruption and other unpleasantness. = This=20 > sounds like a very bad idea. Did you talk about this anywhere (I have = not=20 > caught up on various lists yet, so apologies if this has been = discussed.) Eww. This is indeed pretty bad. I would like to see this commit = reverted. Regards, -- Rui Paulo