From nobody Wed Jul 1 05:49:25 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gqpxN6zGDz6hWpW; Wed, 01 Jul 2026 05:49:28 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gqpxN4ssjz46qG; Wed, 01 Jul 2026 05:49:28 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782884968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RwwBQZjSGIKlY5d9ezkp0SV+IIr1qngMI9iDlf07/qE=; b=E90Ovzinq275Bz7XTu3F4ybDhES2dG/paRFP18PA0VhdseHy2DJjwdYQUGnDP3c46oY2ji FkJTfjaQ+sC25Jum2j+tEpOMV4/Vxqrioa0wVlsi83V4KFQNQzqth3YGwl6Op4PQNLLHCW KDRRm6H57YG2l8UmgDPHttAaoZ39o1Gx5iR43q/J5WxYWigBpJqThnFGL8YCy9G+TPkp7j Nkz3Zfy3MUYCN1YBGvwYR1mS2jaPKI/h1HJgLkbrvfiK0yiM0jysjp0Qnp9ALgtCEYjmzd PZ0ofX6U3/IxPgiZR1p3Aokt1uIxBwxCWA6hHVWSS3pLjwGiAsUF/5Z87mUF+g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782884968; a=rsa-sha256; cv=none; b=LQbg1zxlAIBuONmYL0YFTfwgmhgD07fBy+Mxw1JW4kfROTFntjK9ifdGSgSQftUWoQpnmY SwvfkfHbvv99XAKACYrJe6psgP0ClnpWFxygGVY30KRstNk+RtjEKpxSVrk5oLTFbGAGFh /0mUftu76Ha1yJ71W5WC4JICcIxijRcQAeWfIJW1gCnzQS/eT79t8aWrG0DaXNcOBNvnqb AyIxJubLWsC5EyvsjUind6IZMesd313PwO/zb0kV7P9PxmGouRHE7XI29FkcRWJPmpFPig KNyujp5I0sYIPr0bqdEX7ohELkJVCKqwbaFRaRX0qs0o0PQxT5fcKqB7ygChrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782884968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RwwBQZjSGIKlY5d9ezkp0SV+IIr1qngMI9iDlf07/qE=; b=NJX4kmHevMJF5Yr9+FluR3aq0LXaHNtyqGRaJlQBNQajncLFaSUgiC1NfLwowKLcmIgm+/ fmos05B1x/BfbuIRbL+oU/6qZsjvOg3SVKLv4Vn7FotvmWjCvuSs4Yp07QapMqjWQ1JpU/ nKxATzgELEWnoMIty5k1DzyU6JLc42rD+OjQvS6YaR/VDy7wqv8FWtLuGtg7kVTaJLk85B 4RfsHkb2raVfbuSfCiHgjILBRETjC5RfVzv1+iv7lnQJFTHHdh2b7dpsGr24/n78vJESS6 MR805Jk1kt4MPBDMTeWKijrrJNi/+//UN3xXhO4aiOwwdQq3OyruKpBkiRqm7A== Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:2563:add6:d31:5619]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gqpxM4jKLz14JQ; Wed, 01 Jul 2026 05:49:27 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: git: d6c4cea7740d - main - loopback: improve checksum offloading From: Michael Tuexen In-Reply-To: Date: Wed, 1 Jul 2026 07:49:25 +0200 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?utf-8?Q?Timo_V=C3=B6lker?= Content-Transfer-Encoding: quoted-printable Message-Id: <614DBB5F-461E-4E69-9ADA-8698EE03F804@FreeBSD.org> References: <6a40fe36.39b1d.3aea7fb1@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3864.600.51.1.1) > On 1. Jul 2026, at 06:16, Gleb Smirnoff wrote: >=20 > On Sun, Jun 28, 2026 at 10:57:58AM +0000, Michael Tuexen wrote: > M> commit d6c4cea7740d5c5c673a06ba37e4f1bdcddb2ece > M> Author: Timo V=C3=B6lker > M> AuthorDate: 2026-06-28 10:50:15 +0000 > M> Commit: Michael Tuexen > M> CommitDate: 2026-06-28 10:50:15 +0000 > M>=20 > M> loopback: improve checksum offloading > M> =20 > M> * Allow disabling IFCAP_RXCSUM_IPV6 or IFCAP_TXCSUM_IPV6. > M> * Do not pretend the checksum is correct by setting the = LO_CSUM_SET > M> flags if IFCAP_RXCSUM_IPV6 or IFCAP_RXCSUM is enabled. = Instead, > M> remove the LO_CSUM_SET flags (in case they have been set = somehow) > M> if IFCAP_RXCSUM_IPV6 or IFCAP_RXCSUM is disabled. > M> * Do not unset the transmit checksum offload flags = LO_CSUM_FEATURES or > M> LO_CSUM_FEATURES6 since they now have a meaning for the = receive path. > M> =20 > M> Reviewed by: glebius, pouria, tuexen > M> Okayed by: bz > M> MFC after: 1 week > M> Differential Revision: https://reviews.freebsd.org/D57518 >=20 > I'm guessing this change is responsible for breaking the > netinet/ip_reass_test. The tests inject packets to localhost. Now all > subtests fail, but after each test that creates single packet I see in = 'netstat > -sp ip' increase in 'bad header checksums'. >=20 > Can you please check this? We will do. Thanks for notifying. Best regards Michael >=20 > --=20 > Gleb Smirnoff