Date: Wed, 5 Oct 2022 10:02:01 +0100 From: Andrew Turner <andrew@FreeBSD.org> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 89a9a13c1a91 - main - Remove unneeded FDT checks from phydev and regdev Message-ID: <3428A0F4-1ED5-4C3F-B05D-7EBD9567ECCF@FreeBSD.org> In-Reply-To: <20221005084515.ad2186594090170256a67bff@bidouilliste.com> References: <202210041639.294GdjkP062001@gitrepo.freebsd.org> <20221005084515.ad2186594090170256a67bff@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_88BF194D-9719-4887-93C3-BC88D9AA6C32 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 5 Oct 2022, at 07:45, Emmanuel Vadot <manu@bidouilliste.com> wrote: >=20 > On Tue, 4 Oct 2022 16:39:45 GMT > Andrew Turner <andrew@FreeBSD.org <mailto:andrew@FreeBSD.org>> wrote: >=20 >> The branch main has been updated by andrew: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D89a9a13c1a917715c047ef9b0d7bd3f6= 416bb13b >>=20 >> commit 89a9a13c1a917715c047ef9b0d7bd3f6416bb13b >> Author: Andrew Turner <andrew@FreeBSD.org> >> AuthorDate: 2022-10-04 16:27:59 +0000 >> Commit: Andrew Turner <andrew@FreeBSD.org> >> CommitDate: 2022-10-04 16:37:37 +0000 >>=20 >> Remove unneeded FDT checks from phydev and regdev >>=20 >> They are only ever built when FDT is enabled so there is no need = to >> check for it in the files. >>=20 >> Sponsored by: The FreeBSD Foundation >> --- >> sys/dev/extres/phy/phydev_if.m | 5 ----- >> sys/dev/extres/regulator/regdev_if.m | 6 ------ >> 2 files changed, 11 deletions(-) >=20 > Pretty sure that mmel@'s goal was to make this available for every > platform at one point. > But if someone will do the work re-adding those isn't hard (and I > don't see it happening anytime soon anyway ...). Both of these files only defined one method that takes FDT/OFW specific = types. We can re-add them later if needed, however currently any line = starting with a # is a comment, other than a special case for #include = so they do nothing. I have a local patch to support them so notice when = these failed to build due to opt_platform.h not being included. Andrew --Apple-Mail=_88BF194D-9719-4887-93C3-BC88D9AA6C32 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On 5 Oct 2022, at 07:45, Emmanuel Vadot <<a = href=3D"mailto:manu@bidouilliste.com" = class=3D"">manu@bidouilliste.com</a>> wrote:</div><br = class=3D"Apple-interchange-newline"><div class=3D""><meta = charset=3D"UTF-8" class=3D""><span style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">On Tue, 4 Oct 2022 16:39:45 GMT</span><br style=3D"caret-color:= rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant-caps: normal; font-weight: 400; letter-spacing: = normal; text-align: start; text-indent: 0px; text-transform: none; = white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">Andrew Turner <</span><a href=3D"mailto:andrew@FreeBSD.org" = style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = orphans: auto; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; widows: auto; word-spacing: 0px; = -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" = class=3D"">andrew@FreeBSD.org</a><span style=3D"caret-color: rgb(0, 0, = 0); font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">> wrote:</span><br style=3D"caret-color: rgb(0, 0, 0); = font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><br style=3D"caret-color: rgb(0, 0, = 0); font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><blockquote type=3D"cite" = style=3D"font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = orphans: auto; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; widows: auto; word-spacing: 0px; = -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D"">The branch main has been updated by = andrew:<br class=3D""><br class=3D"">URL: <a = href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D89a9a13c1a917715c047ef9b= 0d7bd3f6416bb13b" = class=3D"">https://cgit.FreeBSD.org/src/commit/?id=3D89a9a13c1a917715c047e= f9b0d7bd3f6416bb13b</a><br class=3D""><br class=3D"">commit = 89a9a13c1a917715c047ef9b0d7bd3f6416bb13b<br class=3D"">Author: = Andrew Turner <<a = href=3D"mailto:andrew@FreeBSD.org" = class=3D"">andrew@FreeBSD.org</a>><br class=3D"">AuthorDate: = 2022-10-04 16:27:59 +0000<br class=3D"">Commit: = Andrew Turner <<a = href=3D"mailto:andrew@FreeBSD.org" = class=3D"">andrew@FreeBSD.org</a>><br class=3D"">CommitDate: = 2022-10-04 16:37:37 +0000<br class=3D""><br = class=3D""> Remove unneeded FDT checks from phydev and = regdev<br class=3D""><br class=3D""> They are only ever = built when FDT is enabled so there is no need to<br = class=3D""> check for it in the files.<br class=3D""><br = class=3D""> Sponsored by: The FreeBSD = Foundation<br class=3D"">---<br class=3D"">sys/dev/extres/phy/phydev_if.m = | 5 -----<br = class=3D"">sys/dev/extres/regulator/regdev_if.m | 6 ------<br class=3D"">2= files changed, 11 deletions(-)<br class=3D""></blockquote><br = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><span = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;" class=3D"">Pretty sure that mmel@'s goal = was to make this available for every</span><br style=3D"caret-color: = rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant-caps: normal; font-weight: 400; letter-spacing: = normal; text-align: start; text-indent: 0px; text-transform: none; = white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">platform at one point.</span><br style=3D"caret-color: rgb(0, = 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: Helvetica; font-size: 12px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">But if someone will do the work re-adding those isn't hard = (and I</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none;" class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none; float: none; display: inline !important;" class=3D"">don't see it = happening anytime soon anyway ...).</span><br style=3D"caret-color: = rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant-caps: normal; font-weight: 400; letter-spacing: = normal; text-align: start; text-indent: 0px; text-transform: none; = white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""></div></blockquote><div><br = class=3D""></div>Both of these files only defined one method that takes = FDT/OFW specific types. We can re-add them later if needed, however = currently any line starting with a # is a comment, other than a special = case for #include so they do nothing. I have a local patch to support = them so notice when these failed to build due to opt_platform.h not = being included.</div><div><br class=3D""></div><div>Andrew</div><div><br = class=3D""></div></body></html>= --Apple-Mail=_88BF194D-9719-4887-93C3-BC88D9AA6C32--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3428A0F4-1ED5-4C3F-B05D-7EBD9567ECCF>