From owner-svn-src-head@freebsd.org Sat Nov 30 19:46:03 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64A511B51F8 for ; Sat, 30 Nov 2019 19:46:03 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47QMLg00fQz4PBX for ; Sat, 30 Nov 2019 19:46:02 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1575143161; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=G7SJe/y/EGw5k+V5M3VfvXGb37OO8w2HyidwHCJ120oRy31GwjEGKMdh9E9j1rDpfH2Vk+T35G//Z xMiW0G2CZwIBO5qWEt1qZdjROiBgfoEQC32rYJ5mRIxnm8FR90KHw5AeG6Uqe3GL8mh6hS0eloZRlA vyD4g23ZLwUFJZj4YH4xZOGSWX12nAGbumbKZheLT0aaMOf79sVdhb2Fq8eVdDnCjiGA9QGgiyr8na nXqs9xTX0dsMKr7iMtTV+8xEf4/gUujzx7GYJGAXGILs0Ks/pjKHsn/ROU8fZv8CFuGEMbXrlOSBaS nC9lffdPdrBbbY7dj+ZEhlrqX29nJ4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=IgCUSmrl9SqL9sp2mQhjUYDjP4W42ci1dt8+QuHuRHs=; b=psUfqBNUILwlxLKjbNS8ruAsXzSdclBHnxL2UvtKpF3qsBF2MIftC694To+k+0O4kMCkDPzQvFj1k 1HHSLj+LMRc8dNzTX553+ebkUCiQ8n6pIV6eM/YBHlHc7F+NYKz4ZD2uUrub8fs2nu6kGj8VFBED2Q JIPUl4UqlMUb7bulv6KvPvq92eFmlMDP6ZG6XRoo6iZouSgrpgX0P7NgDqhjxsTuYrD+raCw8U84gM Vs+/KPFXB6TijqumSmTf8z6UhsheRYIOtzOxcJUK2SKrnREU0jtMl8TCfZUlmsmDDgkKoZK7rK23LY Ae9RCuYFQ+LmezTBLJ1ahUN84lEr0SQ== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=IgCUSmrl9SqL9sp2mQhjUYDjP4W42ci1dt8+QuHuRHs=; b=JWFQMmUBujNL0wNot3DjKMpwv34OFbM9PY1Gl9699MWupw3DIRXbUp8QmvPSlNYGFTn8QEJH6A+SQ Tp0ZnIO+O9qk/8E/6/PSvMFOSk7QDwEZpa9G+0t4hCzOwRVh+cgRuDJVkSTR0mv0QV5R7A8fk7t60S BGNiDJ7Hms8t4/Nn8PSvpwyv2qAsvCdmgWes5cScIsOEc1tBUqmLFEiQpOdDnZRgT+qlYQiAzLyWbM wyEffnyn8I3OL9BC1x9aIjjnP8a1dtgvyKWanr1ueMg12ci8+O7CMEnEAvDAcp6MhRoTil3WAKzzWq ZJl8aUY7JEUPFvfIKl2PBtBbpt/Gqzw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 07eeb242-13aa-11ea-b80c-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 07eeb242-13aa-11ea-b80c-052b4a66b6b2; Sat, 30 Nov 2019 19:45:59 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id xAUJjwYg089354; Sat, 30 Nov 2019 12:45:58 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <94864ce829f8eeb7352ace92b6efdac55e9f1979.camel@freebsd.org> Subject: Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm From: Ian Lepore To: Enji Cooper , Warner Losh Cc: Scott Long , src-committers , svn-src-all , svn-src-head Date: Sat, 30 Nov 2019 12:45:58 -0700 In-Reply-To: References: <201911280232.xAS2WHtb029602@repo.freebsd.org> <41D40355-A16E-48E1-9C11-0C9E42C83A42@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 47QMLg00fQz4PBX X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.77 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.84)[-0.836,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-0.93)[-0.931,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Nov 2019 19:46:03 -0000 On Sat, 2019-11-30 at 11:25 -0800, Enji Cooper wrote: > > On Nov 30, 2019, at 11:01 AM, Warner Losh wrote: > > > > On Sat, Nov 30, 2019 at 11:58 AM Enji Cooper > > wrote: > > > > > On Nov 30, 2019, at 10:03 AM, Warner Losh > > > wrote: > > > > > > > > > > > > On Sat, Nov 30, 2019 at 10:47 AM Enji Cooper < > > > yaneurabeya@gmail.com > wrote: > > > > > > > On Nov 27, 2019, at 6:32 PM, Scott Long > > > > wrote: > > > > > > > > Author: scottl > > > > Date: Thu Nov 28 02:32:17 2019 > > > > New Revision: 355164 > > > > URL: https://svnweb.freebsd.org/changeset/base/355164 < > > > > https://svnweb.freebsd.org/changeset/base/355164> > > > > > > > > Log: > > > > Remove the trm(4) driver > > > > > > > > Differential Revision: > > > > https://reviews.freebsd.org/D22575 < > > > > https://reviews.freebsd.org/D22575> > > > > > > Hi Scott, > > > I believe this driver was removed because it was impacts > > > the CAM GIANT lock removal effort — is that true (I’m asking > > > because the “why” behind the removal is unclear)? > > > > > > Hi Enji, > > > > > > We're trying hard to get rid of all Giant-locked drivers in the > > > tree, either by updating or removal. Since sym(4) provides a > > > super-set of trm(4) and we have recent-ish reports of sym(4) > > > working, it makes sense to trim this driver from the tree. The > > > specific cards it supports aren't all that popular, the couple- > > > extra features that trm(4) gave over sym(4) aren't really that > > > relevant today, and it's been years since trm has had good > > > testing and maintenance. > > > > Warner, > > Thanks so very much for the info :). Glad to see this effort > > taking place, since it’s very needed to modernize FreeBSD and > > improve concurrency in the kernel, as well as reduce the overall > > maintenance burden. > > > > Giant isn't contending, but it's getting in the way of a cleanup of > > the console / kbd system, as well as there being newbus issues in > > highly dynamic systems. With TB and USB4 support on the horizon, we > > need to finally clean that mess up.. I'll post a longer summary of > > what's left. I have a 'doodle' tree that I'm separating out the > > Giant usage to 'driver lock', kbd/console/ddb, newbus, sysctl, and > > WTF is that protecting... I'm tempted to create wtf_lock() and > > wtf_unlock(), but I'm not sure how well that would go over :) > > Sounds great :D… > -Enji > > PS wtf_lock() would be amusing, but probably less of a good idea > these days :D... But naming is important... I was wondering the other day whether Giant would have been misused and overused less if it had been named splhigh_lock. -- Ian