From owner-cvs-src@FreeBSD.ORG Mon Feb 2 19:34:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D69916A4CE; Mon, 2 Feb 2004 19:34:54 -0800 (PST) Received: from gateway.posi.net (adsl-63-201-89-201.dsl.snfc21.pacbell.net [63.201.89.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1323C43D39; Mon, 2 Feb 2004 19:34:52 -0800 (PST) (envelope-from kbyanc@posi.net) Received: from localhost (localhost [127.0.0.1]) by gateway.posi.net (Postfix) with ESMTP id 28D7F6A06C4; Mon, 2 Feb 2004 19:35:00 -0800 (PST) Date: Mon, 2 Feb 2004 19:34:59 -0800 (PST) From: Kelly Yancey To: Brooks Davis In-Reply-To: <20040131225013.GA14981@Odin.AC.HMC.Edu> Message-ID: <20040202193230.D17866@gateway.posi.net> References: <200401270143.i0R1hEIO011023@repoman.freebsd.org> <20040131201747.GO908@cirb503493.alcatel.com.au> <20040131225013.GA14981@Odin.AC.HMC.Edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Peter Jeremy cc: Brooks Davis cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c ifconfig.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 03:34:54 -0000 On Sat, 31 Jan 2004, Brooks Davis wrote: > You are correct. I forgot about that issue. I'll commit this fix > soon. On the plus side, this won't actually happen with real interfaces > because the minimum size of sdl_data is larger then is actually needed > by any interface I've found so in practice you will hit a NUL after the > address. > I've never tried it, but in theory you could fill the sdl_data space with source routing information on a token ring interface with a 6-character name. One better, to the best of my knowledge, you can still corrupt the sdl_data buffer in the same scenario with a 7-character interface name. That has nothing to do with your change, though. Kelly -- Kelly Yancey - kbyanc@{posi.net,FreeBSD.org} - kelly@nttmcl.com Visit the BSD driver database: http://www.posi.net/freebsd/drivers/