From owner-svn-src-all@freebsd.org Wed Mar 4 17:27:11 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50B3E274444; Wed, 4 Mar 2020 17:27:11 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48XgmZ5B9hz4dKb; Wed, 4 Mar 2020 17:27:10 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qt1-f193.google.com with SMTP id h16so1945043qtr.11; Wed, 04 Mar 2020 09:27:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+JhsfjFtzvfhY2IQ+wD7u7y8Uft+M34GGxsIluYbpIc=; b=E4wEVN6WahmrF5q7E7bJ/M3g3ZAa85hvP8tJZayRcwvX0CBRARV8owMnQChwJ4SnuL odVi6k5uRGcOP7WhwYsFGWQmybpIcrXd+jY68FG9W/4JniyBhaIWbcywZ9X1uER9Sx+Z +/9waqfiwj5/jEkLdRl+Pn5SS1V6TZ8pVZOu5ku45tPEX6F9rI/CnR1SV72M5Rx43mAq 1uccQ4H0zYeBEsKoK44zpG5NmEE9c+sbvIjOr6sk+pkUBfjg9nEzI9o/+XW3dootHcHl XZFjS2gs89Ide9hMosg29WSWPTWyIYqZyiWJ7pyeRi/Ik8St3gYEYncEMyxuYDQ3wVmv dhAA== X-Gm-Message-State: ANhLgQ0TQcw5avg57Jht22nxYJoW9VnuhfWfj7Ua4HqaaFLFrCR4tl9z P4WiyBaq9mNMfOuQTb6OCJnPULDQSnU= X-Google-Smtp-Source: ADFU+vsDb96ClaaawpkgS9S4UiiYub/+qEilSCqSjBhpC0EoP3AGkg/0At1X5crZV4Fp8mNJIlpuzg== X-Received: by 2002:ac8:6899:: with SMTP id m25mr3215818qtq.93.1583342828479; Wed, 04 Mar 2020 09:27:08 -0800 (PST) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com. [209.85.222.176]) by smtp.gmail.com with ESMTPSA id a187sm14376346qkc.61.2020.03.04.09.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2020 09:27:08 -0800 (PST) Received: by mail-qk1-f176.google.com with SMTP id b5so2407142qkh.8; Wed, 04 Mar 2020 09:27:08 -0800 (PST) X-Received: by 2002:a37:b984:: with SMTP id j126mr3770242qkf.3.1583342827765; Wed, 04 Mar 2020 09:27:07 -0800 (PST) MIME-Version: 1.0 References: <202002281832.01SIWaEL071685@repo.freebsd.org> <5767791583138727@sas1-c7aad230fe87.qloud-c.yandex.net> <3d54ebc3-a511-a239-136d-c0f638a69351@FreeBSD.org> In-Reply-To: <3d54ebc3-a511-a239-136d-c0f638a69351@FreeBSD.org> From: Ryan Libby Date: Wed, 4 Mar 2020 09:26:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r358439 - head/sys/amd64/include To: Guido Falsi Cc: "Alexander V. Chernikov" , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , vbox@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48XgmZ5B9hz4dKb X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.71 / 15.00]; NEURAL_HAM_MEDIUM(-0.71)[-0.715,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2020 17:27:11 -0000 On Wed, Mar 4, 2020 at 3:27 AM Guido Falsi wrote: > > On 02/03/20 18:13, Ryan Libby wrote: > > On Mon, Mar 2, 2020 at 12:45 AM Alexander V. Chernikov wrote: > >> > >> 28.02.2020, 18:32, "Ryan Libby" : > >>> Author: rlibby > >>> Date: Fri Feb 28 18:32:36 2020 > >>> New Revision: 358439 > >>> URL: https://svnweb.freebsd.org/changeset/base/358439 > >>> > >>> Log: > >>> amd64 atomic.h: minor codegen optimization in flag access > >>> > >>> Previously the pattern to extract status flags from inline assembly > >>> blocks was to use setcc in the block to write the flag to a register. > >>> This was suboptimal in a few ways: > >>> - It would lead to code like: sete %cl; test %cl; jne, i.e. a flag > >>> would just be loaded into a register and then reloaded to a flag. > >>> - The setcc would force the block to use an additional register. > >>> - If the client code didn't care for the flag value then the setcc > >>> would be entirely pointless but could not be eliminated by the > >>> optimizer. > >>> > >>> A more modern inline asm construct (since gcc 6 and clang 9) allows for > >> This effectively restricts kernel builds by all older compilers. > >> Is there any chance of making it conditional depending on the compiler version/features? > > > > Yes, it is possible to test for __GCC_ASM_FLAG_OUTPUTS__. It is more > > maintenance effort going forward. If building current with an old cross > > compiler is an important scenario, we can either revert this and the > > following revision or work up a patch to make it conditional. I'll see > > what that might look like. > > > > Actually this causes emulators/virtualbox-ose port to fail to build: > > In file included from /usr/src/sys/sys/systm.h:44: > /usr/include/machine/atomic.h:230:1: error: invalid output constraint > '=@cce' in asm > ATOMIC_CMPSET(char); > ^ > /usr/include/machine/atomic.h:205:4: note: expanded from macro > 'ATOMIC_CMPSET' > : "=@cce" (res), /* 0 */ \ > ^ > /usr/include/machine/atomic.h:230:1: error: invalid output constraint > '=@cce' in asm > > (and so on) > > > the virtualbox-ose port is forced to use an older clang version due to > crashes when compiled with newer ones. > > Not sure whose responsibility is to fix this. > > Should I file a bug report on bugzilla? > > -- > Guido Falsi We've discussed whether to provide compatibility code for older compilers here: https://reviews.freebsd.org/D23937 There's a bug tracking virtualbox-ose being pinned to an old compiler here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236616 I see you have commented on that bug.