From owner-freebsd-bugs@FreeBSD.ORG  Sat Nov  6 17:40:08 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8099F1065672
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  6 Nov 2010 17:40:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 3E0408FC14
	for <freebsd-bugs@hub.freebsd.org>;
	Sat,  6 Nov 2010 17:40:08 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA6He8QP047567
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 6 Nov 2010 17:40:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA6He8rb047557;
	Sat, 6 Nov 2010 17:40:08 GMT (envelope-from gnats)
Resent-Date: Sat, 6 Nov 2010 17:40:08 GMT
Resent-Message-Id: <201011061740.oA6He8rb047557@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	yamayan <yamayan@wind.sannet.ne.jp>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B49E0106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  6 Nov 2010 17:31:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A24CE8FC08
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat,  6 Nov 2010 17:31:21 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oA6HVKW0006756
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 6 Nov 2010 17:31:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id oA6HVKSC006755;
	Sat, 6 Nov 2010 17:31:20 GMT (envelope-from nobody)
Message-Id: <201011061731.oA6HVKSC006755@www.freebsd.org>
Date: Sat, 6 Nov 2010 17:31:20 GMT
From: yamayan <yamayan@wind.sannet.ne.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/151989: geli version check
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Nov 2010 17:40:08 -0000


>Number:         151989
>Category:       kern
>Synopsis:       geli version check
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 06 17:40:07 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     yamayan
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD genius 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r214545M: Sat Oct 30 14:34:42 JST 2010     root@genius:/usr/obj/usr/src/sys/NYANCO  amd64

>Description:
geli version check accept ONLY newest metadata.
older geli disk cannot attach.
>How-To-Repeat:
older version geli init disk without -b option.
newest version geli attach disk.
>Fix:
geli version check in g_eli_config(sys/geom/eli/g_eli_ctl.c)
  accept older version as same as g_eli_taste(g_eli.c).


Patch attached with submission follows:

--- sys/geom/eli/g_eli_ctl.c.orig	2010-11-06 01:19:09.000000000 +0900
+++ sys/geom/eli/g_eli_ctl.c	2010-11-06 01:20:37.000000000 +0900
@@ -1017,7 +1017,7 @@
 		gctl_error(req, "No '%s' argument.", "version");
 		return;
 	}
-	if (*version != G_ELI_VERSION) {
+	if (*version > G_ELI_VERSION) {
 		gctl_error(req, "Userland and kernel parts are out of sync.");
 		return;
 	}


>Release-Note:
>Audit-Trail:
>Unformatted: