From owner-cvs-all Wed Nov 13 18:48:11 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEE0B37B401; Wed, 13 Nov 2002 18:48:09 -0800 (PST) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FCD843E7B; Wed, 13 Nov 2002 18:48:09 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.3/8.12.3) with ESMTP id gAE2m4Ah073609; Wed, 13 Nov 2002 18:48:04 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.3/8.12.3/Submit) id gAE2m4qw073608; Wed, 13 Nov 2002 18:48:04 -0800 (PST) (envelope-from rizzo) Date: Wed, 13 Nov 2002 18:48:04 -0800 From: Luigi Rizzo To: Maxim Konovalov Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Message-ID: <20021113184804.A73212@xorpc.icir.org> References: <200211131131.gADBViEe010812@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200211131131.gADBViEe010812@repoman.freebsd.org>; from maxim@FreeBSD.ORG on Wed, Nov 13, 2002 at 03:31:44AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG i'd actually shorten the MFC to 3 days because this is a fix for a bug that i introduced around last june (in fact the bug has always been there, but did not harm because in the past the struct ipfw_flow_id was static and so the extra bytes were not dirtied by whatever was on the stack). cheers luigi On Wed, Nov 13, 2002 at 03:31:44AM -0800, Maxim Konovalov wrote: > maxim 2002/11/13 03:31:44 PST > > Modified files: > sys/netinet ip_dummynet.c > Log: > Due to a memory alignment sizeof(struct ipfw_flow_id) is bigger than > ipfw_flow_id structure actual size and bcmp(3) may fail to compare > them properly. Compare members of these structures instead. > > PR: kern/44078 > Submitted by: Oleg Bulyzhin > Reviewed by: luigi > MFC after: 2 weeks > > Revision Changes Path > 1.55 +6 -1 src/sys/netinet/ip_dummynet.c > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message