From nobody Wed Aug 27 21:57:12 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cBz0962Sdz65k0Y; Wed, 27 Aug 2025 21:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cBz090tcKz3FBQ; Wed, 27 Aug 2025 21:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756331833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oeX9+jrr3f9c/hhP4kNCrVe1nfQqd3UN6kRjtDQWV2s=; b=eeSB4i3xcHoIi09PEh2w4Dt7iack0nvRAcT69rlhCDVtDJbNHfrLmgS2R4QIet6i34mcYo K/VbMpoFoSiV0AZsEJF+pRJ4y+hm9jmUDgcBw6ppUCmdsGkooo4ivL6yB/3FACXgCw3BnV dHAc4PeFgSV5oXzfYR3TOAHovqneq9kCAxHTrvZrswtjtmJxP/Z8WKlxiONO27j8m3RwtA xCnIcvSdpPGI+zloXofoaN3Eqj56jYbbcqPs06dovpwy8k0cqGoykl91Ds1GyrS7DRuPa9 PWyLQBIFEqKbH8eSXsDSwN4tYJGYy+bpAtbQQKqBZq1Ox3JWCpsQdpbRVxOD7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756331833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oeX9+jrr3f9c/hhP4kNCrVe1nfQqd3UN6kRjtDQWV2s=; b=M7U8sdzUVkSDONO7eAxwLfcvtPAC20JNDnpU+0lDTFJjpuD7N29X3lP9Z1ne710GRFZGpM sY/HTzUgAxlywI1vGsjsEw+ZgYK9HwRuInVWDVayUiytT456wKQ0zGeSf9GejtIPQoW3I1 feYDFTf71zl4ltlYz16h95vJxepD1khKHyXUepneYocBSe9S+wiB9sf4LEUlHZFa4nmrdO Py7NAXXucCM5T2Oq70JDQcnaw7az8v94w40K7zZ+637onkxIoJYmlNnTSUHAPJPc9Zd8Vl PIDRmx3aIDt6iluZA34O8oAnzoqIZ5/Ioxn+9ksIeBnTMeipfXHDSpA07QLxYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756331833; a=rsa-sha256; cv=none; b=xoEoen7S7RU3DjTngaFM4nevv0vQxCDFFTTt68832kBbSsc7xYx2qhzVYHgh/zXIADB9AR WQOnaFZVdPR8XBpU10xPoPYbZJAWcDrtwKrNiLtgu01TKEql55jUDHeapdM8KsQ8KXPGxN 5ApUj0+7ll4/r9Lcc2XSJZQmvZG9Tpr5y/+efvwl3+nNNydDaT1eirNOCkpgvMiFiLWF/r syDBM+/kdhZPXiUQNjXHox9nPJcMLFeDjfmNHHGRYn+dD/GODpx/k9uLP26t51cTRVfEW1 V1VZhQbkMSkLFIVi23TNILTae9O5ReRyEIzBYl/eUO+Qhw5H5HOhUcTn23LjMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cBz090MkXzhWL; Wed, 27 Aug 2025 21:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57RLvCZD026560; Wed, 27 Aug 2025 21:57:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57RLvC73026557; Wed, 27 Aug 2025 21:57:12 GMT (envelope-from git) Date: Wed, 27 Aug 2025 21:57:12 GMT Message-Id: <202508272157.57RLvC73026557@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: ef73953ebdc2 - main - gpioc: remove unnecessary bus_generic_* calls List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ef73953ebdc22fdcab014ac3359c7089789e5d4f Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=ef73953ebdc22fdcab014ac3359c7089789e5d4f commit ef73953ebdc22fdcab014ac3359c7089789e5d4f Author: Ahmad Khalifa AuthorDate: 2025-08-27 21:26:37 +0000 Commit: Ahmad Khalifa CommitDate: 2025-08-27 21:38:32 +0000 gpioc: remove unnecessary bus_generic_* calls gpioc never has any children, so there's no need to call these. Reviewed by: jhb Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D51933 --- sys/dev/gpio/gpioc.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/dev/gpio/gpioc.c b/sys/dev/gpio/gpioc.c index 212445334b27..5a60f939dc78 100644 --- a/sys/dev/gpio/gpioc.c +++ b/sys/dev/gpio/gpioc.c @@ -621,7 +621,6 @@ static int gpioc_detach(device_t dev) { struct gpioc_softc *sc = device_get_softc(dev); - int err; if (sc->sc_ctl_dev) destroy_dev(sc->sc_ctl_dev); @@ -632,9 +631,6 @@ gpioc_detach(device_t dev) } free(sc->sc_pin_intr, M_GPIOC); - if ((err = bus_generic_detach(dev)) != 0) - return (err); - return (0); } @@ -1066,9 +1062,6 @@ static device_method_t gpioc_methods[] = { DEVMETHOD(device_probe, gpioc_probe), DEVMETHOD(device_attach, gpioc_attach), DEVMETHOD(device_detach, gpioc_detach), - DEVMETHOD(device_shutdown, bus_generic_shutdown), - DEVMETHOD(device_suspend, bus_generic_suspend), - DEVMETHOD(device_resume, bus_generic_resume), DEVMETHOD_END };