From owner-cvs-all@FreeBSD.ORG Wed Mar 26 07:14:14 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F2F637B404; Wed, 26 Mar 2003 07:14:14 -0800 (PST) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id B27D643F3F; Wed, 26 Mar 2003 07:14:12 -0800 (PST) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.8/8.12.8) with ESMTP id h2QFEBjx020544; Wed, 26 Mar 2003 18:14:11 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.8/8.12.6/Submit) id h2QFEBjE020543; Wed, 26 Mar 2003 18:14:11 +0300 (MSK) (envelope-from ache) Date: Wed, 26 Mar 2003 18:14:11 +0300 From: "Andrey A. Chernov" To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20030326151410.GA20472@nagual.pp.ru> References: <200303192025.h2JKPjNr000550@repoman.freebsd.org> <20030320050712.GA48184@nagual.pp.ru> <20030320054502.GA4308@HAL9000.homeunix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030320054502.GA4308@HAL9000.homeunix.com> User-Agent: Mutt/1.5.4i X-Spam-Status: No, hits=-32.5 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,USER_AGENT_MUTT autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: das@FreeBSD.org Subject: Re: cvs commit: src/contrib/gdtoa gdtoaimp.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2003 15:14:17 -0000 On Wed, Mar 19, 2003 at 21:45:02 -0800, David Schultz wrote: > Do > you see anything else I should bug the vendor about while I'm at > it? With nowdays variant there is error in gethex.c: CONST unsigned char *decpt, *s0, *s, *s1; ... char decimalpoint = *localeconv()->decimal_point; ... if (*s == decimalpoint) { ^^^ It fails, if decimal point is in upper half of code table, i.e. negative char. Obvious fix: unsigned char decimalpoint ... -- Andrey A. Chernov http://ache.pp.ru/