From owner-freebsd-current@FreeBSD.ORG  Wed Jul 14 18:47:14 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EF2EF16A4CE; Wed, 14 Jul 2004 18:47:13 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 55D4B43D45; Wed, 14 Jul 2004 18:47:13 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i6EIlC8R012940;
	Wed, 14 Jul 2004 20:47:12 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Gleb Smirnoff <glebius@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 14 Jul 2004 22:42:40 +0400."
             <20040714184240.GB11214@cell.sick.ru> 
Date: Wed, 14 Jul 2004 20:47:12 +0200
Message-ID: <12939.1089830832@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: Robert Watson <rwatson@freebsd.org>
cc: current@freebsd.org
Subject: Re: Some netgraph node global locking patches 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jul 2004 18:47:14 -0000

In message <20040714184240.GB11214@cell.sick.ru>, Gleb Smirnoff writes:
>On Wed, Jul 14, 2004 at 08:36:01PM +0200, Poul-Henning Kamp wrote:
>P> >Yes it does. But qsort() already used in ng_ppp is as much recursive as
>P> >qsort_r() is. It will help us to get rid of global variable.
>P> >I Cc phk@ to this mail, because he copied qsort() to libkern from libc.
>P> 
>P> It was put there to get rid of a couple of badly implemented bubble
>P> sorts.
>P> 
>P> It is true that qsort() is recursive, but it is limited to log2(N)
>P> levels and kernel programmers hopefully don't routinely sort arrays
>P> of hundreds of things in the kernel.
>
>>From a snap view I see no problems copying qsort_r() to libkern. What
>do you think? It will help us to get rid of global in ng_ppp.

Ok for me.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.