From owner-freebsd-stable Fri Nov 3 3:55: 4 2000 Delivered-To: freebsd-stable@freebsd.org Received: from updraft.jp.freebsd.org (updraft.jp.FreeBSD.ORG [210.157.158.42]) by hub.freebsd.org (Postfix) with ESMTP id DD4B437B4C5 for ; Fri, 3 Nov 2000 03:55:00 -0800 (PST) Received: from castle2.jp.FreeBSD.org (castle2.jp.FreeBSD.org [210.226.20.120]) by updraft.jp.freebsd.org (8.9.3+3.2W/8.7.3) with ESMTP id UAA01962 for ; Fri, 3 Nov 2000 20:54:59 +0900 (JST) (envelope-from matusita@jp.FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by castle2.jp.FreeBSD.org (8.11.0+3.3W/8.11.0) with ESMTP/inet id eA3Bsxs13597 for ; Fri, 3 Nov 2000 20:54:59 +0900 (JST) (envelope-from matusita@jp.FreeBSD.org) X-Face: '*aj"d@ijeQ:/X}]oM5c5Uz{ZZZk90WPt>a^y4$cGQp8:!H\W=hSM;PuNiidkc]/%,;6VGu e+`&APmz|P;F~OL/QK%;P2vU>\j4X.8@i%j6[%DTs_3J,Fff0)*oHg$A.cDm&jc#pD24WK@{,"Ef!0 P\):.2}8jo-BiZ?X&t$V X-User-Agent: Mew/1.94.2 XEmacs/21.2 (Notus) X-FaceAnim: (-O_O-)(O_O- )(_O- )(O- )(- -)( -O)( -O_)( -O_O)(-O_O-) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Dispatcher: imput version 20000228(IM140) Lines: 46 From: Makoto MATSUSHITA To: stable@freebsd.org Subject: src/sys/modules/linux of RELENG_4 is not 'make -j' safe Date: Fri, 03 Nov 2000 20:54:56 +0900 Message-Id: <20001103205456L.matusita@jp.FreeBSD.org> Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I've found that current src/sys/modules/linux for RELENG_4 is not 'make -j' safe. It maybe causes a problem if you want to make a module. This problem comes from recent MI/MD changes to linux module. Here is a sample session: % make obj /usr/obj/usr/src/sys/modules/linux created for /usr/src/sys/modules/linux % make -j 2 @ -> /usr/src/sys machine -> /usr/src/sys/i386/include echo "#define COMPAT_43 1" > opt_compat.h touch opt_linux.h touch opt_vmpage.h gzip -cn /usr/src/sys/modules/linux/linux.8 > linux.8.gz perl @/kern/vnode_if.pl -h @/kern/vnode_if.src sh @/kern/makesyscalls.sh @/i386/linux/syscalls.master @/i386/linux/syscalls.conf sh @/kern/makesyscalls.sh @/i386/linux/syscalls.master @/i386/linux/syscalls.conf sed -e 's|i386/linux/linux_proto\.h|linux_proto.h|g' linux_sysent.c > linux_sysent.c.fixup mv -f linux_sysent.c.fixup linux_sysent.c sed -e 's|i386/linux/linux_proto\.h|linux_proto.h|g' linux_sysent.c > linux_sysent.c.fixup mv -f linux_sysent.c.fixup linux_sysent.c (.... deleted ...) cc -O -pipe -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/../include -mpreferred-stack-boundary=2 -c linux_sysent.c sh @/kern/genassym.sh linux_genassym.o > linux_assym.h linux_sysent.c:21: warning: cast discards qualifiers from pointer target type linux_sysent.c:229: redefinition of `linux_sysent' linux_sysent.c:19: `linux_sysent' previously defined here linux_sysent.c:231: warning: cast discards qualifiers from pointer target type *** Error code 1 1 error This is because linux_sysent.c is broken: % ls -l /usr/obj/usr/src/sys/modules/linux/linux_sysent.c -rw-r--r-- 1 root wheel 29487 Nov 3 20:48 /usr/obj/usr/src/sys/modules/linux/linux_sysent.c % grep linux_sysent /usr/obj/usr/src/sys/modules/linux/linux_sysent.c struct sysent linux_sysent[] = { struct sysent linux_sysent[] = { It seems that this file contains two linux_sysent[] definition. -- - Makoto `MAR' MATSUSHITA To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message