From owner-svn-src-head@FreeBSD.ORG  Thu Nov  7 22:13:09 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 6CA60C4B;
 Thu,  7 Nov 2013 22:13:09 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 324CC21F9;
 Thu,  7 Nov 2013 22:13:09 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
 [127.0.0.1])
 by troutmask.apl.washington.edu (8.14.7/8.14.7) with ESMTP id rA7MD8uR062235; 
 Thu, 7 Nov 2013 14:13:08 -0800 (PST)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.14.7/8.14.7/Submit) id rA7MD8H4062234;
 Thu, 7 Nov 2013 14:13:08 -0800 (PST) (envelope-from sgk)
Date: Thu, 7 Nov 2013 14:13:08 -0800
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Ian Lepore <ian@FreeBSD.org>
Subject: Re: svn commit: r257818 - in head/lib/msun: . src
Message-ID: <20131107221308.GA61870@troutmask.apl.washington.edu>
References: <201311072120.rA7LKY1J061512@svn.freebsd.org>
 <1383860529.31172.233.camel@revolution.hippie.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1383860529.31172.233.camel@revolution.hippie.lan>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org, Steve Kargl <kargl@FreeBSD.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Nov 2013 22:13:09 -0000

On Thu, Nov 07, 2013 at 02:42:09PM -0700, Ian Lepore wrote:
> On Thu, 2013-11-07 at 21:20 +0000, Steve Kargl wrote:
> > --- head/lib/msun/src/s_round.c	Thu Nov  7 21:16:32 2013	(r257817)
> > +++ head/lib/msun/src/s_round.c	Thu Nov  7 21:20:34 2013	(r257818)
> > @@ -52,3 +52,7 @@ round(double x)
> >  		return (-t);
> >  	}
> >  }
> > +
> > +#if (LDBL_MANT_DIG == 53)
> > +__weak_reference(round, roundl);
> > +#endif
> 
> I don't think that's a complete fix.  I got a linker "undefined
> reference" error when testing your patch.  I decided to make sure it
> wasn't a -DNO_CLEAN artifact and did a fresh build, and it just failed:
> 

I just can't win today.  I forgot "#include <float.h>" where
LDBL_MANT_DIG is defined.  Can you try?

Index: src/s_round.c
===================================================================
--- src/s_round.c       (revision 257818)
+++ src/s_round.c       (working copy)
@@ -27,6 +27,8 @@
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD$");
 
+#include <float.h>
+
 #include "math.h"
 #include "math_private.h"

-- 
Steve