From owner-svn-src-all@freebsd.org Wed Nov 22 19:28:14 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D630DF371D; Wed, 22 Nov 2017 19:28:14 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DA836617E; Wed, 22 Nov 2017 19:28:13 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id vAMJSCT1087647 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 22 Nov 2017 11:28:12 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id vAMJSCHM087646; Wed, 22 Nov 2017 11:28:12 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 22 Nov 2017 11:28:12 -0800 From: Gleb Smirnoff To: =?utf-8?Q?Micha=C5=82?= Krawczyk Cc: Marcin Wojtas , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325239 - head/sys/dev/ena Message-ID: <20171122192812.GI1063@FreeBSD.org> References: <201710311631.v9VGVNOs058255@repo.freebsd.org> <20171122000816.GH1063@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 19:28:14 -0000 Michał, thanks for explanation. Looks like in this case software counters are indeed superior to hardware ones. On Wed, Nov 22, 2017 at 05:19:54PM +0100, Michał Krawczyk wrote: M> Hi Gleb, M> We are counting the statistics in the software because of the alignment M> with the newest ena-com API (HAL) which is delivered to us from NIC's M> vendor. M> M> Regarding fetching them periodically - there are 2 issues with that. First M> of all, there may be problem with the counter overflow. Secondly, reading M> statistics on demand requires sending admin message to the NIC and then the M> cv_timedwait function is called to wait for the response. However there are M> a lot of witness warnings when the cv_timedwait is called from the M> if_get_counter() context, because of the non sleepable lock which is hold M> there (I don't remember exactly which lock was causing this issue). M> M> Best regards, M> Michal M> M> 2017-11-22 1:08 GMT+01:00 Gleb Smirnoff : M> M> > Hi Martin and Michal, M> > M> > On Tue, Oct 31, 2017 at 04:31:23PM +0000, Marcin Wojtas wrote: M> > M> Author: mw M> > M> Date: Tue Oct 31 16:31:23 2017 M> > M> New Revision: 325239 M> > M> URL: https://svnweb.freebsd.org/changeset/base/325239 M> > M> M> > M> Log: M> > M> Rework counting of hardware statistics in ENA driver M> > M> M> > M> Do not read all statistics from the device, instead count them in the M> > M> driver except from RX drops - they are received directly from the NIC M> > M> in the AENQ descriptor. M> > M> M> > M> Submitted by: Michal Krawczyk M> > M> Reviewed by: imp M> > M> Obtained from: Semihalf M> > M> Sponsored by: Amazon.com, Inc. M> > M> Differential Revision: https://reviews.freebsd.org/D12852 M> > M> > Is it possible not to count them in software, as well as not fetch M> > them from hardware periodically, but instead just fetch them on M> > demand, when either if_get_counter() or a sysctl is called? M> > M> > That would be more efficient. M> > M> > -- M> > Gleb Smirnoff M> > -- Gleb Smirnoff