From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 8 15:30:01 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B0434414 for ; Wed, 8 Jan 2014 15:30:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9C74F147D for ; Wed, 8 Jan 2014 15:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s08FU1Ux005166 for ; Wed, 8 Jan 2014 15:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s08FU1PD005165; Wed, 8 Jan 2014 15:30:01 GMT (envelope-from gnats) Date: Wed, 8 Jan 2014 15:30:01 GMT Message-Id: <201401081530.s08FU1PD005165@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Ruben van Staveren Subject: Re: kern/183077: don't have the compiler inline txg_quiesce so that zilstat works X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Ruben van Staveren List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jan 2014 15:30:01 -0000 The following reply was made to PR kern/183077; it has been noted by GNATS. From: Ruben van Staveren To: bug-followup@FreeBSD.org, Ruben van Staveren Cc: Subject: Re: kern/183077: don't have the compiler inline txg_quiesce so that zilstat works Date: Wed, 8 Jan 2014 16:28:50 +0100 --Apple-Mail=_C4725950-B205-4C65-B29C-4D6B3A39551E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This is also applicable to FreeBSD 10.0-PRERELEASE r260387M Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c = (revision 260387) +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c (working = copy) @@ -354,7 +354,7 @@ * On return, the transaction group has reached a stable state in which = it can * then be passed off to the syncing context. */ -static void +static __attribute__ ((noinline)) void txg_quiesce(dsl_pool_t *dp, uint64_t txg) { tx_state_t *tx =3D &dp->dp_tx; --Apple-Mail=_C4725950-B205-4C65-B29C-4D6B3A39551E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAlLNbrIACgkQZ88+mcQxRw0W5QCeNuWTu/yR/4AE5iDnvv0QZdn8 mGUAnihSjg3xpKW8f7F5cImZnPmALeyl =+URu -----END PGP SIGNATURE----- --Apple-Mail=_C4725950-B205-4C65-B29C-4D6B3A39551E--