From owner-cvs-all@FreeBSD.ORG Wed Nov 15 22:36:11 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 98BD316A4E6; Wed, 15 Nov 2006 22:36:11 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EA8743D72; Wed, 15 Nov 2006 22:35:49 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAFMZdon007537; Wed, 15 Nov 2006 15:35:44 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <455B963A.4050200@samsco.org> Date: Wed, 15 Nov 2006 15:35:38 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: John Baldwin References: <200611152004.kAFK4vfe058983@repoman.freebsd.org> <20061115215119.GA74745@rambler-co.ru> <20061115215142.GB74745@rambler-co.ru> <200611151718.56506.jhb@freebsd.org> In-Reply-To: <200611151718.56506.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ruslan Ermilov , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/em if_em.c if_em.h src/sys/dev/mpt mpt.h mpt_pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2006 22:36:11 -0000 John Baldwin wrote: > On Wednesday 15 November 2006 16:51, Ruslan Ermilov wrote: >> On Thu, Nov 16, 2006 at 12:51:19AM +0300, Ruslan Ermilov wrote: >>> On Wed, Nov 15, 2006 at 08:04:57PM +0000, John Baldwin wrote: >>>> jhb 2006-11-15 20:04:57 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/dev/bce if_bce.c >>>> sys/dev/em if_em.c if_em.h >>>> sys/dev/mpt mpt.h mpt_pci.c >>>> Log: >>>> Add MSI support to em(4), bce(4), and mpt(4). For now, we only > support >>>> devices that support a maximum of 1 message, and we use that 1 message >>>> instead of the INTx rid 0 IRQ with the same interrupt handler, etc. >>>> >>>> Revision Changes Path >>>> 1.19 +11 -3 src/sys/dev/bce/if_bce.c >>>> 1.164 +11 -2 src/sys/dev/em/if_em.c >>>> 1.56 +1 -0 src/sys/dev/em/if_em.h >>>> 1.31 +1 -0 src/sys/dev/mpt/mpt.h >>>> 1.39 +14 -1 src/sys/dev/mpt/mpt_pci.c >>>> >>> How will the "vmstat -i" output look like for MSI-enabled devices? >>> >> irqXXXX, where XXXX>=1024? > > s/1024/256/ > There is a problem here, though. Newbus prints out the IRQ number after a successful device probe phase. It has no knowledge of MSI at that point, so it just prints out the traditional IRQ value. At some point, this needs to be fixed. Having the driver tell newbus about its MSI intentions in the probe routine is unrealistic, so there is no quick fix there. Probably need to delay printing the device message until later in the attach routine, once the driver has set up all of the resources. Scott