From nobody Thu Jan 29 00:03:30 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f1fVq0WgRz6QQ2Y for ; Thu, 29 Jan 2026 00:03:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f1fVp4hYdz3Glq for ; Thu, 29 Jan 2026 00:03:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769645010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AYNmVmfLRO5GYuxJNl+4N4Tgdjupj+QR1z7ubwqBZXU=; b=G7H4Fdj8RH6e+JiaRDgKraZiwG1/XLXy/I1ZiWnC/vu5C1pXANhf34g9u/yAZgADcvo9TL LADhUGFxKCijmSMB2wtXRWf9zxe3/PuTogDUf0RYzd3j1UBEEcnRGGS7ktVt01B6xWoETm RvhA/DoOnpRlFh8JQAjgzL+OiLYTNQbJBqZtyJp+xZ7weq4omolqgh+L20H5D5Q/RRBY/A CwCYJPzsk2wlxV8u76XbqdSZhBqqrIXHklEpiVTIgM0NRhvTGkC4IdDba/+AttWh8lgfrp F2Cy+Asnfl9OEOxBoNHoLUkUuPTEJB1aA2EVnmP4cVN4J7yN6Ef5nMiSQM9Jtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769645010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AYNmVmfLRO5GYuxJNl+4N4Tgdjupj+QR1z7ubwqBZXU=; b=XOYCSB62pUl/ZMNeXPWx4XiOaFukFexpa4vg9xXi1XP2ORHpQ5E8ycQihA4EjVjrUlvPYv 0W07tudsYJfCQV9D5Nuh0Bu+GonhTr4QS360stSijWP6YOU3q7HJAvlIaKlMBHFauC1BxT 6sgdBH1mJCZoiLGtFVOC6pEq/G4JKrO+JP1XpUPhVB4h+YuY+gcjzIsoalClcbmafhPZc3 ZyQCx0tQX62bGqOEjX9w1mEs36nuJZulsbjbn6w6AKjaTwQxqIT4rDESZPnbjkBtuAiput /pgooeLOIx9J5tAQjuv8TfzveFGPJ9aEktQNz60gbLLeo1OCDYq6N7NLdEXtbg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769645010; a=rsa-sha256; cv=none; b=ey7sfASRckA3XnLyGe3cheQ1Z5z8u4olBZZeIGirY0YYjpCfX0uUVcImtT6LTeN+gAzcLp XGscs28g4WbI5dQtYh9/yT50jrQAUQF+A/bLO3E7gEhC1ui/3vdCpImfci7KunX4KFR8Df wBQZJB6RKj9UBu9ndUDJ9J67TEPH/d61WRx8db4eoQBvZEG3G2HA+VVLkf91YEFgoZH8o0 /qJ0SM6nNZEQNDb0lFci+6ZwTSA69Q1WTMAOKcYruuG+/1KBZmSdftLo/1gULDLLtpGQEn p1v5gfs6rO8I3QJxji6YhYT+Gx4Ox53wUKkq4bDCl5HPeBDiLp565/HdsAUuJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f1fVp48mGzXq for ; Thu, 29 Jan 2026 00:03:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id da09 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Jan 2026 00:03:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Mark Johnston From: John Baldwin Subject: git: c8553cad48cb - stable/14 - smartpqi: Avoid declaring extern inline functions List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c8553cad48cb91e23a98865efa6336418b8a8130 Auto-Submitted: auto-generated Date: Thu, 29 Jan 2026 00:03:30 +0000 Message-Id: <697aa3d2.da09.7d370d3e@gitrepo.freebsd.org> The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=c8553cad48cb91e23a98865efa6336418b8a8130 commit c8553cad48cb91e23a98865efa6336418b8a8130 Author: Mark Johnston AuthorDate: 2026-01-16 19:49:22 +0000 Commit: John Baldwin CommitDate: 2026-01-29 00:02:20 +0000 smartpqi: Avoid declaring extern inline functions Each C file is compiled separately so these functions can't be inlined except in the file where they are defined. Since these functions aren't used outside smartpqi_request.c, just do the simple thing and make them private to that file. Reported by: gcc Reviewed by: jrhall Fixes: c558eca47970 ("smartpqi: update to version 4660.0.2002") Differential Revision: https://reviews.freebsd.org/D54732 (cherry picked from commit 75c591b26723711d7a38f2a5df7aecc28198cd83) --- sys/dev/smartpqi/smartpqi_prototypes.h | 4 ---- sys/dev/smartpqi/smartpqi_request.c | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sys/dev/smartpqi/smartpqi_prototypes.h b/sys/dev/smartpqi/smartpqi_prototypes.h index f2eb328b6bc1..fdf69e38fa59 100644 --- a/sys/dev/smartpqi/smartpqi_prototypes.h +++ b/sys/dev/smartpqi/smartpqi_prototypes.h @@ -167,10 +167,6 @@ int pqisrc_send_tmf(pqisrc_softstate_t *, pqi_scsi_dev_t const *, rcb_t *, rcb_t *, int); int pqisrc_write_current_time_to_host_wellness(pqisrc_softstate_t *softs); int pqisrc_write_driver_version_to_host_wellness(pqisrc_softstate_t *softs); -extern inline void pqisrc_aio_build_cdb(aio_req_locator_t *, uint32_t, - rcb_t *, uint8_t *); -extern inline boolean_t pqisrc_aio_req_too_big(pqisrc_softstate_t *, pqi_scsi_dev_t *, - rcb_t const *, aio_req_locator_t *, uint32_t); void pqisrc_build_aio_common(pqisrc_softstate_t *, pqi_aio_req_t *, rcb_t *, uint32_t); void pqisrc_build_aio_R1_write(pqisrc_softstate_t *, diff --git a/sys/dev/smartpqi/smartpqi_request.c b/sys/dev/smartpqi/smartpqi_request.c index d993897cd1f9..bd2c21954a49 100644 --- a/sys/dev/smartpqi/smartpqi_request.c +++ b/sys/dev/smartpqi/smartpqi_request.c @@ -1492,7 +1492,7 @@ pqisrc_handle_blk_size_diffs(aio_req_locator_t *l) * handle based on dev type, Raid level, and encryption status. * TODO: make limits dynamic when this becomes possible. */ -inline boolean_t +static boolean_t pqisrc_aio_req_too_big(pqisrc_softstate_t *softs, pqi_scsi_dev_t *device, rcb_t const *rcb, aio_req_locator_t *l, uint32_t disk_blk_cnt) @@ -1636,7 +1636,7 @@ pqisrc_aio_show_locator_info(pqisrc_softstate_t *softs, } /* build the aio cdb */ -inline void +static void pqisrc_aio_build_cdb(aio_req_locator_t *l, uint32_t disk_blk_cnt, rcb_t *rcb, uint8_t *cdb) {