From nobody Thu May 1 08:24:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zp6XS5SqVz5tpvF; Thu, 01 May 2025 08:24:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zp6XS3RcGz3bKY; Thu, 01 May 2025 08:24:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746087848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PtTgq1hZE06MVJnsIa55gmFuddfynBRhv1a4TlbIYPA=; b=txq4io67bqD5kzkn1hWg7wN3CnnbEMrCDhaRtHHUR6mqBLbxVcGaRzYshYBTJzhSIW5rq6 +nQMyibQhoSfyDwcB8PG0ntrM9s7A5QW7HEeWasx2KLtm1YJYEO62Cgs7cEWxPG9AKYGj4 7BjzHggXQ3uxI6k8HImzt3AcC82YVfm4+Greuzj1bX2wdN8DSXtZqDrkaUk0fx9ik+bnjp 8lsrnrsH3bDfNDlYr5kCGzyy9aQ3mSR9lrlRgcMsSopNr98NxXRNfkJ7a5V0MK1jaukK3X LPHQcNVmKcqXqE0yK8BcSnC7S8xHWCctsQD2CuahsW12rvU922Es9bReU4lMbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746087848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PtTgq1hZE06MVJnsIa55gmFuddfynBRhv1a4TlbIYPA=; b=dG3Ek0NlNHhFWzCBKAqoq05PIEGrNGTpg7lZ8/hTAqD16rpjDvZKm0JB7O9WXUOUt5oWX+ hO4CWEypUkjRI3FNuo3iqTaK2+kNWnIQPgDXnIMNiKgEvx3otc73P9hY+VfNsECubDujLo kBlqY6nfsdJiLGSbkpyVN0Ld1u4hX2u827vMsC/dnfhwnwC32+VhDczXR0ajcEWK6A9WP2 CsGi72QoruAR4st2E02KqZXhn5REl7cDbwmI/l3HCZtWVpzNwWn8oSS1t0AoGaZOmGgxwM O7jeJ15V6TGjptpyKrc3ZN7vsY6pchq45/EDFIBjgP+9Gbd45Skt9POtgkblJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746087848; a=rsa-sha256; cv=none; b=wbIXobbol8wJ5X1Ap4Pr59lV1N5cfhfBWkqwgrY11PMphUndNl5Ie8Q9rT/rnZNVxiJEFf tXImde4+jlanTw9eKoz+zJGVKirqtHWCvjqlEdIUteL9rSWj6Gm4h6KrG2/3xFadiI21Wq 0PmmdIZZ5O5zl44T6gpdgBFiIZQzPCYPi5bGuMettjbJZwxPL9jgCSzJ1WtWPmrPTsXgL1 IYdxVolODzTeHXyEPXMqimKUwidQVVNSi+TQVhjdjZWo6BOgFbwgz6k9ufRGK4BvZ3GJAx iGKy7OARHgN5PaV1SSP1cTA2DOmFA3N9RKce1us8JyXjJXs9fbapVq5kn6j3nA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zp6XS2ZWMz4pM; Thu, 01 May 2025 08:24:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5418O8O5079836; Thu, 1 May 2025 08:24:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5418O81E079833; Thu, 1 May 2025 08:24:08 GMT (envelope-from git) Date: Thu, 1 May 2025 08:24:08 GMT Message-Id: <202505010824.5418O81E079833@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 4e3a6fe0134e - main - Make sure the memory region definitions are zeroed before use. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4e3a6fe0134e67fdcd1279b06427e5f26dd08f78 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=4e3a6fe0134e67fdcd1279b06427e5f26dd08f78 commit 4e3a6fe0134e67fdcd1279b06427e5f26dd08f78 Author: Luiz Otavio O Souza AuthorDate: 2025-04-26 15:23:27 +0000 Commit: Kristof Provost CommitDate: 2025-05-01 08:23:38 +0000 Make sure the memory region definitions are zeroed before use. Since only 32bits of the values are read from the fdt, the existing values can compromise the results. Fixes the boot on the Netgate 3100. Reviewed by: andrew, mmel Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D50083 --- sys/dev/fdt/fdt_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/fdt/fdt_common.c b/sys/dev/fdt/fdt_common.c index 53d47c26b53d..1fea4c6f1392 100644 --- a/sys/dev/fdt/fdt_common.c +++ b/sys/dev/fdt/fdt_common.c @@ -441,6 +441,7 @@ fdt_foreach_reserved_region(fdt_mem_region_cb cb, void *arg) reservep = (pcell_t *)&reserve; for (i = 0; i < tuples; i++) { + memset(&mr, 0, sizeof(mr)); rv = fdt_data_to_res(reservep, addr_cells, size_cells, (u_long *)&mr.mr_start, (u_long *)&mr.mr_size); @@ -484,6 +485,7 @@ fdt_foreach_reserved_mem(fdt_mem_region_cb cb, void *arg) /* XXX: Does a no-map of a dynamic range make sense? */ continue; + memset(&mr, 0, sizeof(mr)); fdt_data_to_res(reg, addr_cells, size_cells, (u_long *)&mr.mr_start, (u_long *)&mr.mr_size); @@ -526,6 +528,7 @@ fdt_foreach_mem_region(fdt_mem_region_cb cb, void *arg) regp = (pcell_t *)® for (i = 0; i < tuples; i++) { + memset(&mr, 0, sizeof(mr)); rv = fdt_data_to_res(regp, addr_cells, size_cells, (u_long *)&mr.mr_start, (u_long *)&mr.mr_size);