From owner-freebsd-current@FreeBSD.ORG Thu Apr 22 12:49:01 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F65116A4CE for ; Thu, 22 Apr 2004 12:49:01 -0700 (PDT) Received: from cmsrelay02.mx.net (cmsrelay02.mx.net [165.212.11.111]) by mx1.FreeBSD.org (Postfix) with SMTP id 0750F43D5F for ; Thu, 22 Apr 2004 12:49:01 -0700 (PDT) (envelope-from noackjr@alumni.rice.edu) Received: from cmsapps01.cms.usa.net (165.212.11.136) by cmsoutbound.mx.net with SMTP; 22 Apr 2004 19:49:00 -0000 Received: from optimator.noacks.org [66.136.23.165] by cmsapps01.cms.usa.net (ASMTP/noackjr@usa.net) via mtad (C8.MAIN.3.13N) with ESMTP id 747iDVTW50316M36; Thu, 22 Apr 2004 19:48:56 GMT X-USANET-Auth: 66.136.23.165 AUTH noackjr@usa.net optimator.noacks.org Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id DC9246139; Thu, 22 Apr 2004 14:48:55 -0500 (CDT) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 43096-10; Thu, 22 Apr 2004 14:48:53 -0500 (CDT) Received: from alumni.rice.edu (compgeek [192.168.1.10]) by optimator.noacks.org (Postfix) with ESMTP id E04846110; Thu, 22 Apr 2004 14:48:52 -0500 (CDT) Message-ID: <408821A3.8010605@alumni.rice.edu> Date: Thu, 22 Apr 2004 14:48:51 -0500 From: Jon Noack User-Agent: Mozilla Thunderbird 0.6a (Windows/20040419) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Peter Losher References: <200404221758.i3MHwdGZ032309@green.homeunix.org> <200404221140.47242.Peter_Losher@isc.org> In-Reply-To: <200404221140.47242.Peter_Losher@isc.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at noacks.org cc: current@freebsd.org Subject: Re: sleep mutex panic on 5.2.1-RELEASE X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2004 19:49:01 -0000 On 4/22/2004 1:40 PM, Peter Losher wrote: > On Thursday 22 April 2004 10:58, Brian Fundakowski Feldman wrote: >> Chances are this bug does not exist anymore. Robert Watson rewrote >> a large amount of the pipe code to improve its locking and >> security, and I hammered out some left-over bugs that showed up >> with SMP testing. Please try either upgrading to -CURRENT or, if >> you are not using MAC, these two diffs might be all you need: >> >> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/pipe.h.diff?r1=1.25&r2=1.26 >> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/sys_pipe.c.diff?r1=1.170&r2=1.158 > > Thanks for the pointers (I'd rather stay in the release branch if I can), > the patches applied cleanly, but it has a issue when compiling it in. > > -=- > cc -c -O -pipe -mcpu=pentiumpro -Wall -Wredundant-decls -Wnested-externs > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. > -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica > -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/dev/ath > -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm > -D_KERNEL -include opt_global.h -fno-common -finline-limit=15000 > -fno-strict-aliasing -mno-align-long-strings > -mpreferred-stack-boundary=2 -ffreestanding > -Werror /usr/src/sys/kern/sys_pipe.c > /usr/src/sys/kern/sys_pipe.c: In function `pipe': > /usr/src/sys/kern/sys_pipe.c:364: warning: implicit declaration of > function `fdunused' > *** Error code 1 > -=- > > Is there something else I might be missing here? See revision 1.163 of src/sys/kern/sys_pipe.c. It references the new file descriptor allocation code: http://lists.freebsd.org/pipermail/cvs-src/2004-January/016623.html Either remove that part of the diff (it's just the one line with 'fdunused' -- line 364 of the patched file) or pull in the new file descriptor allocation code as well. This seems to be the only issue I see after brief inspection of the commit history. However, the gremlins are clever... Jon Noack