From owner-freebsd-current@FreeBSD.ORG  Tue Dec  2 15:30:05 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CD9A2B0C
 for <current@freebsd.org>; Tue,  2 Dec 2014 15:30:05 +0000 (UTC)
Received: from mail-wg0-x235.google.com (mail-wg0-x235.google.com
 [IPv6:2a00:1450:400c:c00::235])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 606C4897
 for <current@freebsd.org>; Tue,  2 Dec 2014 15:30:05 +0000 (UTC)
Received: by mail-wg0-f53.google.com with SMTP id l18so17337336wgh.40
 for <current@freebsd.org>; Tue, 02 Dec 2014 07:30:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=TFGZNXKQOXyjJlxds/1jVbwogzXWR0PDLjf6OKbEiwI=;
 b=UQGyaZrPhY1Kz4zO0vBWumuhQ7mCfVMQZW5kj4tJTFLJUf2WNxUvs2DTbedTMEA5YL
 Rh9EqDMkW7x3o2kkgvtVntroJv2Op3n6VYOVH7SzjtlMb+hUnyVhuXWo87vQoAlUiptV
 YnnkaW9q2vq+5S6bJr/93/QDgORfgLq/sdCUL98xiIeRa3WspCKNdS29rpHAgEZF4pRO
 Rh1fJZTdVPnZwc+PA/EQfKGk7GwX70rxUbjbtDDF0ESYB8UUzpk+R+3Up7hhRtjEs0hL
 YPkLJIKAVc/HdTMnkqbjisFvGPx0Og6vLlFCGJ4PslrnpcG+MZeNAbkpZosp/aVq2qDS
 Aulw==
MIME-Version: 1.0
X-Received: by 10.194.24.103 with SMTP id t7mr84518660wjf.15.1417534203646;
 Tue, 02 Dec 2014 07:30:03 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.216.106.195 with HTTP; Tue, 2 Dec 2014 07:30:03 -0800 (PST)
In-Reply-To: <547D5A6E.5050806@gmail.com>
References: <547D5A6E.5050806@gmail.com>
Date: Tue, 2 Dec 2014 07:30:03 -0800
X-Google-Sender-Auth: 3xybYmgC-OjnaAW3tGCAgRDaGJM
Message-ID: <CAJ-VmonW=m_rZwu_Z5yH+e+F-wShVg=UKndshjm3R=bNZSe-Uw@mail.gmail.com>
Subject: Re: compiling failed with RSS enabled
From: Adrian Chadd <adrian@freebsd.org>
To: "Eric L. Camachat" <eric.camachat@gmail.com>
Content-Type: text/plain; charset=UTF-8
Cc: FreeBSD Current <current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Dec 2014 15:30:05 -0000

Ugh!

please file a bug and I'll go take a look at the code soon.

Thanks!


-a


On 1 December 2014 at 22:21, Eric L. Camachat <eric.camachat@gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> current failed to compile due to queues uninitialized at line 2883 in
> if_igb.c.
> from the context I guess it should be n_queues instead of queues.
>
> Index: sys/dev/e1000/if_igb.c
> ===================================================================
> - --- sys/dev/e1000/if_igb.c    (revision 275391)
> +++ sys/dev/e1000/if_igb.c      (working copy)
> @@ -2880,7 +2880,7 @@
>
>  #ifdef RSS
>         /* If we're doing RSS, clamp at the number of RSS buckets */
> - -     if (queues > rss_getnumbuckets())
> +       if (n_queues > rss_getnumbuckets())
>                 queues = rss_getnumbuckets();
>  #endif
>
>
> Eric
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iF4EAREIAAYFAlR9WmoACgkQSfBQu3oOwYxnrQD6Ah1uhoNaM3YTXHdOpOA7hw4j
> vZUCA9VU6n/jhUEneVkBALETmBfQudmEz9/eqnmsmer8RbulQdqIKTa8InSvE2yw
> =jLcf
> -----END PGP SIGNATURE-----