From owner-freebsd-ports-bugs@freebsd.org Thu Mar 4 08:53:11 2021 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 65FEE567C0C for ; Thu, 4 Mar 2021 08:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Drl532GZ2z4rlf for ; Thu, 4 Mar 2021 08:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4DD6E567BA4; Thu, 4 Mar 2021 08:53:11 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4D9F0567B4E for ; Thu, 4 Mar 2021 08:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Drl531Yxbz4rld for ; Thu, 4 Mar 2021 08:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 273A81A34C for ; Thu, 4 Mar 2021 08:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1248rBjh077395 for ; Thu, 4 Mar 2021 08:53:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1248rBTI077394 for ports-bugs@FreeBSD.org; Thu, 4 Mar 2021 08:53:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 254006] net/samba(all versions): rc.d/samba_server stop/restart patch for restart crash Date: Thu, 04 Mar 2021 08:53:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pen@lysator.liu.se X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2021 08:53:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254006 --- Comment #1 from Peter Eriksson --- Comment on attachment 222968 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222968 Patch to fix samba_server rc.d script to wait for all processes to die >--- samba_server.orig 2021-03-04 09:38:24.177530000 +0100 >+++ samba_server 2021-03-04 09:37:48.721550000 +0100 >@@ -126,11 +126,27 @@ > rcvar=3D${name}_enable > command=3D"/usr/local/sbin/${name}" > pidfile=3D"${samba_server_piddir}/${name}.pid" >+ masterpid=3D"" >+ if [ "${rc_arg}" =3D "stop" ] ; then >+ masterpid=3D"`cat ${pidfile}`" >+ fi >+=09 > # Daemon should be enabled and running > if ( [ -n "${rcvar}" ] && checkyesno "${rcvar}" ) || [ -n "$force_run" ]= ; then > run_rc_command "${_rc_prefix}${rc_arg}" ${rc_extra_args} > # If any of the commands failed, take it as a global result > result=3D$((${result} || $?)) >+ >+ if [ "${rc_arg}" =3D "stop" -a "$masterpid" !=3D "" ] ; then >+ if pgrep -q -s "$masterpid"; then >+ echo -n "Waiting for all ${name} subprocesses to terminate..." >+ while pgrep -q -s "$masterpid"; do >+ echo -n "." >+ sleep 1 >+ done >+ echo "" >+ fi >+ fi > fi > done > return ${result} --=20 You are receiving this mail because: You are the assignee for the bug.=