From owner-cvs-all Thu Feb 21 1:31:44 2002 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 8ABE237B402; Thu, 21 Feb 2002 01:31:38 -0800 (PST) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id g1L9Vam33850; Thu, 21 Feb 2002 09:31:36 GMT (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.2/8.12.2) with ESMTP id g1L9VIuJ036795; Thu, 21 Feb 2002 09:31:18 GMT (envelope-from brian@freebsd-services.com) Message-Id: <200202210931.g1L9VIuJ036795@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Matthew Dillon Cc: John Baldwin , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/bin/ps print.c In-Reply-To: Message from Matthew Dillon of "Wed, 20 Feb 2002 21:13:47 PST." <200202210513.g1L5DlS93001@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 21 Feb 2002 09:31:18 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > :> It's a lot easier to just have ps axl show it, since the wchan > :> field is otherwise unused. Alternatively we could create a > :> synthesize field 'mwchan' which replaces the default 'wchan' for > :> ps output that does this combo. > : > :Sounds good to me. I actually did something like this for top. In top I had > :all mutex names start with a * to differentiate them from wait channel names, > :can you do a similar thing for mwchan? > : > :John Baldwin <>< http://www.FreeBSD.org/~jhb/ > :"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > Hmm. I don't think it's necessary, because the process state is > 'M' if it's blocked in a mutex, and I think I'd rather have the field > width. > > In anycase, here is the patch. I'll throw this into the tree tomorrow > if there are no objections. The only potential problem I can see is > that the header will now be 'MWCHAN' instead of 'WCHAN'. If that turns > out to be a problem we could make the header print as 'WCHAN'. I think this interface change is ok as long as it's not MFC'd. -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message