From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Aug 9 19:50:04 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B026D106566B for ; Thu, 9 Aug 2012 19:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 64A238FC0C for ; Thu, 9 Aug 2012 19:50:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q79Jo4Vt025104 for ; Thu, 9 Aug 2012 19:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q79Jo4PO025103; Thu, 9 Aug 2012 19:50:04 GMT (envelope-from gnats) Resent-Date: Thu, 9 Aug 2012 19:50:04 GMT Resent-Message-Id: <201208091950.q79Jo4PO025103@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "A.J. Kehoe IV (Nanoman)" Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F26721065674 for ; Thu, 9 Aug 2012 19:48:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id DB9608FC12 for ; Thu, 9 Aug 2012 19:48:47 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q79JmlxI036011 for ; Thu, 9 Aug 2012 19:48:47 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q79Jmllb036010; Thu, 9 Aug 2012 19:48:47 GMT (envelope-from nobody) Message-Id: <201208091948.q79Jmllb036010@red.freebsd.org> Date: Thu, 9 Aug 2012 19:48:47 GMT From: "A.J. Kehoe IV (Nanoman)" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/170517: [patch] Correct audio/jack Dependency Declaration X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2012 19:50:04 -0000 >Number: 170517 >Category: ports >Synopsis: [patch] Correct audio/jack Dependency Declaration >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Aug 09 19:50:04 UTC 2012 >Closed-Date: >Last-Modified: >Originator: A.J. Kehoe IV (Nanoman) >Release: 9.0 >Organization: Nanoman's Company >Environment: FreeBSD localhost 9.0-RELEASE-p3 FreeBSD 9.0-RELEASE-p3 #0: Tue Jun 12 02:52:29 UTC 2012 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 >Description: The FreeBSD port audio/jack uses automatic detection to declare an optional dependency. This causes problems for port and package management. >How-To-Repeat: >Fix: I've attached a patch that corrects this by using the method suggested in the FreeBSD Porter's Handbook on the "Dependencies" page under "Problems Caused by Automatic Dependencies": http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html Patch attached with submission follows: --- ports/audio/jack/Makefile.old 2012-05-30 07:27:09.000000000 -0400 +++ ports/audio/jack/Makefile 2012-08-09 15:47:04.868404000 -0400 @@ -35,7 +35,8 @@ MAN1= jackd.1 jackstart.1 -OPTIONS_DEFINE= ALSA DOCS +OPTIONS_DEFINE= ALSA DOCS READLINE +READLINE_DESC= Enable Readline support .include @@ -47,7 +48,7 @@ PLIST_SUB+= DOCS="@comment " .endif -.if exists(${LOCALBASE}/lib/libreadline.so.6) +.if ${PORT_OPTIONS:MREADLINE} LIB_DEPENDS+= readline.6:${PORTSDIR}/devel/readline .endif >Release-Note: >Audit-Trail: >Unformatted: