From owner-freebsd-fs@FreeBSD.ORG  Fri Mar 25 22:40:14 2011
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 17F07106564A
	for <freebsd-fs@hub.freebsd.org>; Fri, 25 Mar 2011 22:40:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E1FAA8FC15
	for <freebsd-fs@hub.freebsd.org>; Fri, 25 Mar 2011 22:40:13 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p2PMeDYw015824
	for <freebsd-fs@freefall.freebsd.org>; Fri, 25 Mar 2011 22:40:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p2PMeDU9015823;
	Fri, 25 Mar 2011 22:40:13 GMT (envelope-from gnats)
Date: Fri, 25 Mar 2011 22:40:13 GMT
Message-Id: <201103252240.p2PMeDU9015823@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/152079: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Mar 2011 22:40:14 -0000

The following reply was made to PR kern/152079; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/152079: commit references a PR
Date: Fri, 25 Mar 2011 22:31:42 +0000 (UTC)

 Author: kib
 Date: Fri Mar 25 22:31:28 2011
 New Revision: 220014
 URL: http://svn.freebsd.org/changeset/base/220014
 
 Log:
   Report EBUSY instead of EROFS for attempt of deleting or renaming the
   root directory of msdosfs mount. The VFS code would handle deletion
   case itself too, assuming VV_ROOT flag is not lost. The msdosfs_rename()
   should also note attempt to rename root via doscheckpath() or different
   mount point check leading to EXDEV. Nonetheless, keep the checks for now.
   
   The change is inspired by NetBSD change referenced in PR, but return
   EBUSY like kern_unlinkat() does.
   
   PR:	kern/152079
   MFC after:	1 week
 
 Modified:
   head/sys/fs/msdosfs/msdosfs_lookup.c
 
 Modified: head/sys/fs/msdosfs/msdosfs_lookup.c
 ==============================================================================
 --- head/sys/fs/msdosfs/msdosfs_lookup.c	Fri Mar 25 22:17:24 2011	(r220013)
 +++ head/sys/fs/msdosfs/msdosfs_lookup.c	Fri Mar 25 22:31:28 2011	(r220014)
 @@ -458,7 +458,7 @@ foundroot:
  		 * Don't allow deleting the root.
  		 */
  		if (blkoff == MSDOSFSROOT_OFS)
 -			return EROFS;				/* really? XXX */
 +			return (EBUSY);
  
  		/*
  		 * Write access to directory required to delete files.
 @@ -491,7 +491,7 @@ foundroot:
  	 */
  	if (nameiop == RENAME && (flags & ISLASTCN)) {
  		if (blkoff == MSDOSFSROOT_OFS)
 -			return EROFS;				/* really? XXX */
 +			return (EBUSY);
  
  		error = VOP_ACCESS(vdp, VWRITE, cnp->cn_cred, cnp->cn_thread);
  		if (error)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"