Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Aug 2012 17:55:17 +0000 (UTC)
From:      Randall Stewart <rrs@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r239334 - head/sys/netinet
Message-ID:  <201208161755.q7GHtHHZ048693@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rrs
Date: Thu Aug 16 17:55:16 2012
New Revision: 239334
URL: http://svn.freebsd.org/changeset/base/239334

Log:
  Its never a good idea to double free the same
  address.
  
  MFC after:	1 week (after the other commits ahead of this gets MFC'd)

Modified:
  head/sys/netinet/in.c

Modified: head/sys/netinet/in.c
==============================================================================
--- head/sys/netinet/in.c	Thu Aug 16 17:27:11 2012	(r239333)
+++ head/sys/netinet/in.c	Thu Aug 16 17:55:16 2012	(r239334)
@@ -573,7 +573,7 @@ in_control(struct socket *so, u_long cmd
 	}
 	TAILQ_REMOVE(&ifp->if_addrhead, &ia->ia_ifa, ifa_link);
 	IF_ADDR_WUNLOCK(ifp);
-	ifa_free(&ia->ia_ifa);				/* if_addrhead */
+/*	ifa_free(&ia->ia_ifa);	- Double free?? */	/* if_addrhead */
 
 	IN_IFADDR_WLOCK();
 	TAILQ_REMOVE(&V_in_ifaddrhead, ia, ia_link);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208161755.q7GHtHHZ048693>