From nobody Fri Jul 28 03:04:15 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RBstP69Jfz4q0VQ for ; Fri, 28 Jul 2023 03:04:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RBstP4Vhtz3JKC for ; Fri, 28 Jul 2023 03:04:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51de9c2bc77so2048796a12.3 for ; Thu, 27 Jul 2023 20:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1690513467; x=1691118267; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QhnKoQrY2f9in1ckieogr5Na42UVSRI3qHh6ZYWjjVs=; b=anD6Uq9LLAPgdeiAduaPwa07gUUvBbe6+lOBhtGhIHLlYljxWKPRd8epErHFDAyFfD YU8vhFvKrQLLg5d6zjXCPHmNRgjrIWfEkNgaOS/KaY1IdUYvUOdZrteWct2udqv267v5 mN5UuwQ1L450615xP2sM/Xm+tH3UJJvhhmLcASIVQv/qZS3h08otm7wMkqRp1RmXBXBz d07tIdbDmYzUCQ6E2+E/pQC2KkYuxngrqaEJeD3MeMQEZRgHrOzBzmcMbnaZZ6ErIJZ+ Ouc4FKigdYpcauDeL1jUMnFaj6FKZUcQUxQ7+5lQ3NTrVY+tpiwr3RfqKhSfVxxZwc2p tdqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690513467; x=1691118267; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QhnKoQrY2f9in1ckieogr5Na42UVSRI3qHh6ZYWjjVs=; b=WcmdsRunf9j2tSCioRHbXJuZ/rVBnJSQ53l0qy7I8ocouXFQXlNXeDWhaY+8/S5mhA I4HAaaI4yNCo92dmDlOfKvQrCuMS/GiZLOGXgt6Ua6FEHKc05sklQZRKHFw+4iYc3o0X Q0uKiJFmB7qyGrIW3qxTCz/jRFahS1d4OKh9e391MGYyTjW5UUA2TJEMz18M+t9IFJAP pvO8q6CYAbnsvzD3ggSU6vHFr9hO1+6NxsgmRJ1UburP4SzCOCkIW1+TpDb02E/jnl2k efUU3EiepRRs0w0154WTt2TlB45V9l+LADXA7flyJLSVgeU4+x9+Tie7QBUEb71c2aPz EDiA== X-Gm-Message-State: ABy/qLZk2rxqBR09LMiiqCGA27ausVvZDqCMof2Ayzk3Vji/a0/YLsFs JO239secE3aPxNySAwXg500gaKMd4aRnRLbVo8u2xg== X-Google-Smtp-Source: APBJJlGzSSqEtEOMZqVK8BXE5fjZslBNxM/Dv/bOHK5m2Uerti3XFsrKP4cYhLQTRxqbIG6XoXzTf3fStGMU2nFwfP0= X-Received: by 2002:aa7:ca59:0:b0:522:3081:ddba with SMTP id j25-20020aa7ca59000000b005223081ddbamr625206edt.15.1690513466385; Thu, 27 Jul 2023 20:04:26 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202307070510.3675AWZS051152@gitrepo.freebsd.org> <65b0e348-b27d-f641-1004-6f76ff3ebfbd@FreeBSD.org> In-Reply-To: <65b0e348-b27d-f641-1004-6f76ff3ebfbd@FreeBSD.org> From: Warner Losh Date: Thu, 27 Jul 2023 21:04:15 -0600 Message-ID: Subject: Re: git: 971bac5ace7a - main - kbd: consolidate kb interfaces (phase one) To: Renato Botelho Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000a6fb7f0601835612" X-Rspamd-Queue-Id: 4RBstP4Vhtz3JKC X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --000000000000a6fb7f0601835612 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 27, 2023 at 5:48=E2=80=AFAM Renato Botelho = wrote: > On 07/07/23 02:10, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262349fa2808188a= 11a5ffeed > > > > commit 971bac5ace7a3c2262349fa2808188a11a5ffeed > > Author: Michael > > AuthorDate: 2023-07-07 02:32:45 +0000 > > Commit: Warner Losh > > CommitDate: 2023-07-07 05:10:18 +0000 > > > > kbd: consolidate kb interfaces (phase one) > > > > Refactor to eliminate duplicated rate and delay tables, with minor > style > > tweaks for changed lines. Remove an obsolete comment about needin= g > to > > convert from microseconds to ticks (that's done elsewhere). Remove > > traiing whitespace in kbdcontrol.c. > > > > Except for the new warning, no change in behavior > > > > Sponsored by: DSS GmbH > > Reviewed by: imp [minor style tweaks as well] > > Pull Request: https://github.com/freebsd/pull/683 > > Differential Revision: https://reviews.freebsd.org/D38818 > > --- > > sys/dev/adb/adb_kbd.c | 12 ++------- > > sys/dev/atkbdc/atkbd.c | 18 +++++--------- > > sys/dev/gpio/gpiokeys.c | 10 ++------ > > sys/dev/hid/hkbd.c | 10 ++------ > > sys/dev/kbdmux/kbdmux.c | 23 +++++------------ > > sys/dev/usb/input/ukbd.c | 10 ++------ > > sys/dev/vkbd/vkbd.c | 18 +++++--------- > > sys/sys/kbio.h | 7 ++++++ > > usr.sbin/kbdcontrol/kbdcontrol.c | 53 > +++++++++++++++++++++------------------- > > 9 files changed, 61 insertions(+), 100 deletions(-) > > After this change I started seeing following error building kbdcontrol: > > Building /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcontrol/kbdcontrol.o > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > undeclared identifier 'kbdelays'; did you mean 'ndelays'? > static const int ndelays =3D nitems(kbdelays); > ^~~~~~~~ > ndelays > /usr/include/sys/param.h:324:28: note: expanded from macro 'nitems' > #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > declared here > static const int ndelays =3D nitems(kbdelays); > ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of > undeclared identifier 'kbdelays'; did you mean 'ndelays'? > static const int ndelays =3D nitems(kbdelays); > ^~~~~~~~ > ndelays > /usr/include/sys/param.h:324:42: note: expanded from macro 'nitems' > #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > declared here > static const int ndelays =3D nitems(kbdelays); > ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: error: subscripted > value is not an array, pointer, or vector > static const int ndelays =3D nitems(kbdelays); > ^~~~~~~~~~~~~~~~ > /usr/include/sys/param.h:324:44: note: expanded from macro 'nitems' > #define nitems(x) (sizeof((x)) / sizeof((x)[0])) > ~~~^~ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > undeclared identifier 'kbrates' > static const int nrepeats =3D nitems(kbrates); > ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of > undeclared identifier 'kbrates' > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: error: use of > undeclared identifier 'kbdelays'; did you mean 'ndelays'? > if (delay <=3D kbdelays[n]) > ^~~~~~~~ > ndelays > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' > declared here > static const int ndelays =3D nitems(kbdelays); > ^ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: error: subscripted > value is not an array, pointer, or vector > if (delay <=3D kbdelays[n]) > ~~~~~~~~^~ > /usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: error: use of > undeclared identifier 'kbrates' > if (repeat <=3D kbrates[n]) > ^ > 8 errors generated. > *** Error code 1 > I haven't seen this. How do I recreate this? Does this happen on a clean build? Warner --000000000000a6fb7f0601835612 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Jul 27, 2023 at 5:48=E2=80=AF= AM Renato Botelho <garga@freebsd.or= g> wrote:
On 07/07/23 02:10, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D971bac5ace7a3c2262349fa2808188a11a5ffeed<= /a>
>
> commit 971bac5ace7a3c2262349fa2808188a11a5ffeed
> Author:=C2=A0 =C2=A0 =C2=A0Michael <git@paepcke.de>
> AuthorDate: 2023-07-07 02:32:45 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2023-07-07 05:10:18 +0000
>
>=C2=A0 =C2=A0 =C2=A0 kbd: consolidate kb interfaces (phase one)
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Refactor to eliminate duplicated rate and delay ta= bles, with minor style
>=C2=A0 =C2=A0 =C2=A0 tweaks for changed lines.=C2=A0 Remove an obsolete= comment about needing to
>=C2=A0 =C2=A0 =C2=A0 convert from microseconds to ticks (that's don= e elsewhere). Remove
>=C2=A0 =C2=A0 =C2=A0 traiing whitespace in kbdcontrol.c.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Except for the new warning, no change in behavior<= br> >=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0DSS GmbH
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 imp [minor style tweaks as well]
>=C2=A0 =C2=A0 =C2=A0 Pull Request:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0https://github.com/freebsd/pull/683
>=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 https://revi= ews.freebsd.org/D38818
> ---
>=C2=A0 =C2=A0sys/dev/adb/adb_kbd.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 12 ++-------
>=C2=A0 =C2=A0sys/dev/atkbdc/atkbd.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0| 18 +++++---------
>=C2=A0 =C2=A0sys/dev/gpio/gpiokeys.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = | 10 ++------
>=C2=A0 =C2=A0sys/dev/hid/hkbd.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 10 ++------
>=C2=A0 =C2=A0sys/dev/kbdmux/kbdmux.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = | 23 +++++------------
>=C2=A0 =C2=A0sys/dev/usb/input/ukbd.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= | 10 ++------
>=C2=A0 =C2=A0sys/dev/vkbd/vkbd.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | 18 +++++---------
>=C2=A0 =C2=A0sys/sys/kbio.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 7 ++++++
>=C2=A0 =C2=A0usr.sbin/kbdcontrol/kbdcontrol.c | 53 ++++++++++++++++++++= +-------------------
>=C2=A0 =C2=A09 files changed, 61 insertions(+), 100 deletions(-)

After this change I started seeing following error building kbdcontrol:

Building /usr/obj/usr/src/amd64.amd64/usr.sbin/kbdcontrol/kbdcontrol.o
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of
undeclared identifier 'kbdelays'; did you mean 'ndelays'? static const int ndelays =3D nitems(kbdelays);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ndelays
/usr/include/sys/param.h:324:28: note: expanded from macro 'nitems'=
#define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((x)) / sizeof((x)[0]))<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' declared here
static const int ndelays =3D nitems(kbdelays);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:35: error: use of
undeclared identifier 'kbdelays'; did you mean 'ndelays'? static const int ndelays =3D nitems(kbdelays);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ndelays
/usr/include/sys/param.h:324:42: note: expanded from macro 'nitems'=
#define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((x)) / sizeof((x)[0]))<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 ^
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' declared here
static const int ndelays =3D nitems(kbdelays);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:28: error: subscripted
value is not an array, pointer, or vector
static const int ndelays =3D nitems(kbdelays);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~~~~~~~~~
/usr/include/sys/param.h:324:44: note: expanded from macro 'nitems'=
#define nitems(x)=C2=A0 =C2=A0 =C2=A0 =C2=A0(sizeof((x)) / sizeof((x)[0]))<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0~~~^~
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of
undeclared identifier 'kbrates'
static const int nrepeats =3D nitems(kbrates);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:98:36: error: use of
undeclared identifier 'kbrates'
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:17: error: use of
undeclared identifier 'kbdelays'; did you mean 'ndelays'? =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0if (delay <=3D kbdelays[n])
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ndelays
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:97:18: note: 'ndelays' declared here
static const int ndelays =3D nitems(kbdelays);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1072:25: error: subscripted
value is not an array, pointer, or vector
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0if (delay <=3D kbdelays[n])
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ~~~~~~~~^~
/usr/src/usr.sbin/kbdcontrol/kbdcontrol.c:1076:18: error: use of
undeclared identifier 'kbrates'
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0if (repeat <=3D kbrates[n])
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
8 errors generated.
*** Error code 1

I haven't seen thi= s. How do I recreate this? Does this happen on a clean build?

Warner
--000000000000a6fb7f0601835612--