Date: Sat, 8 Sep 2001 14:55:48 +0200 From: Thierry Thomas <thierry@thomas.as> To: "G. Paul Ziemba" <paul@treehouse.napa.ca.us> Cc: freebsd-stable@FreeBSD.ORG, freebsd-ports@FreeBSD.ORG Subject: Re: freebsd-4.3 newsx-1.4 history.c fix for DO_TAGGED_HASH Message-ID: <20010908145548.A20695@graf.pompo.net> In-Reply-To: <20010908015442.A13609@hairball.treehouse.napa.ca.us>; from paul@treehouse.napa.ca.us on Sat, Sep 08, 2001 at 01:54:43AM -0700 References: <20010908015442.A13609@hairball.treehouse.napa.ca.us>
next in thread | previous in thread | raw e-mail | index | archive | help
Le 8 Sep 01 à 1:54:43 +0000, G. Paul Ziemba écrivait :
> Thanks for your newsx-1.4 port. I built mine against an INN
> that had tagged-hash enabled and encountered the problem that
> all of newsx's history lookups indicated that the article was
> already present.
>
> Traced this to dbzfetch (in the DO_TAGGED_HASH case) returning 0
> for message-ids it couldn't find, and 0 was interpreted as having
> found the article. Here's the fix:
>
>
> --- history.c.orig Thu Apr 8 03:56:13 1999
> +++ history.c Fri Sep 7 23:38:35 2001
> @@ -142,6 +142,9 @@
> OFFSET_T offset;
> # ifdef DO_TAGGED_HASH
> offset = dbzfetch(key);
> + if (!offset) { /* gpz 010907 start */
> + offset = -1;
> + } /* gpz 010907 end */
> # else
> idxrec ionevalue;
> idxrecext iextvalue;
> @@ -161,6 +164,8 @@
> log_msg(L_DEBUGMORE,"msgid %s not in history",msgid);
> return 0;
> }
> + log_msg(L_DEBUGMORE,"dbzver=6, msgid %s IS in history, off=%d",
> + msgid, offset);
> }
> /* OK, we found it */
> return 1;
At this time, I do not use tagged-hash (the inn Makefile says "Uses much
less memory but is somewhat slower"), but I shall have a look to your
patch as soon as possible.
Thanks.
--
Th. Thomas.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010908145548.A20695>