From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 23 23:26:32 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22224106566C; Tue, 23 Nov 2010 23:26:32 +0000 (UTC) (envelope-from ohauer@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 128E68FC0C; Tue, 23 Nov 2010 23:26:32 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oANNQVSS053302; Tue, 23 Nov 2010 23:26:31 GMT (envelope-from ohauer@freefall.freebsd.org) Received: (from ohauer@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oANNQVx2053298; Tue, 23 Nov 2010 23:26:31 GMT (envelope-from ohauer) Date: Tue, 23 Nov 2010 23:26:31 GMT Message-Id: <201011232326.oANNQVx2053298@freefall.freebsd.org> To: ohauer@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org, ohauer@FreeBSD.org From: ohauer@FreeBSD.org Cc: Subject: Re: ports/151995: net-mgmt/nagios-plugins: new plugin to check CPU usage X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2010 23:26:32 -0000 Synopsis: net-mgmt/nagios-plugins: new plugin to check CPU usage Responsible-Changed-From-To: freebsd-ports-bugs->ohauer Responsible-Changed-By: ohauer Responsible-Changed-When: Tue Nov 23 23:13:34 UTC 2010 Responsible-Changed-Why: Hi Marian, your first port Makefile was nearly perfect ;) If possible use next time tar instead of rar if you provide additional files. I've reworked the port to not download the script. The script can be delivered with the port since it is a small one. Do you really need values behind the "." or is a full integer OK? If so "vmstat -c 2 -n 0 | tail -n 1" or "uptime" is a way faster than "top -n -d 2 | awk ..." I've uploaded the rewritten port for your review, feel free to change the vmstat command back to top it is only a suggestion. http://people.freebsd.org/~ohauer/diffs/nagios-check_cpu_usage/ http://www.freebsd.org/cgi/query-pr.cgi?pr=151995