From owner-svn-src-projects@FreeBSD.ORG Wed Jan 7 11:50:43 2015 Return-Path: <owner-svn-src-projects@FreeBSD.ORG> Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3EA9567D; Wed, 7 Jan 2015 11:50:43 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BD18564231; Wed, 7 Jan 2015 11:50:42 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t07BoefY091281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 7 Jan 2015 14:50:40 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t07BoeIE091280; Wed, 7 Jan 2015 14:50:40 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 7 Jan 2015 14:50:40 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Subject: Re: svn commit: r276461 - projects/ifnet/sys/netinet Message-ID: <20150107115040.GB15484@FreeBSD.org> References: <201412310952.sBV9qws7043801@svn.freebsd.org> <CAJ-VmokLS2qp=Nw-Yqow45Sr3+c9o=GL6abmcdze1fruarX7Pw@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAJ-VmokLS2qp=Nw-Yqow45Sr3+c9o=GL6abmcdze1fruarX7Pw@mail.gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-projects@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org> X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" <svn-src-projects.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/> List-Post: <mailto:svn-src-projects@freebsd.org> List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 07 Jan 2015 11:50:43 -0000 Adrian, On Wed, Dec 31, 2014 at 08:43:11AM -0800, Adrian Chadd wrote: A> I like the accessor macro methods for various bits here. A> A> How about we stage out these simpleish changes into something that A> lands in -HEAD sooner rather than later? I'd like to, but this doesn't seem possible to me :( A> (There are discussions to be had about the attach API; I'm mostly A> worried about how every new optional field may end up needing a KBI A> change to do rather than right now where new optional fields end up A> having defaults that the driver doesn't have to implement itself.) The plan is that drivers use sparse initializers, so we can add fields to if_attach_args. If we add something that is backward incompatible, then we bump ifat_version. Later if_compat.c will emerge, that will have a collection of converting functions from older if_attach_args to newer. -- Totus tuus, Glebius.