Date: Thu, 31 Aug 2017 07:59:54 -0400 From: Dan Langille <dan@langille.org> To: Emanuel Haupt <ehaupt@critical.ch> Cc: svn-ports-head@freebsd.org, Dan Langille <dvl@FreeBSD.org>, svn-ports-all@freebsd.org, Jan Beich <jbeich@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r448998 - head/net-mgmt/tcpreplay Message-ID: <7662236E-0981-4BB7-9D23-A95CCC51ED9D@langille.org> In-Reply-To: <20170831110451.1ec8b8a6dac597f5ec567782@critical.ch> References: <201708301932.v7UJW1tH094312@repo.freebsd.org> <1sns-okrn-wny@FreeBSD.org> <01088B7D-A035-458C-9A23-70EA8381AE66@langille.org> <20170831110451.1ec8b8a6dac597f5ec567782@critical.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 31, 2017, at 5:04 AM, Emanuel Haupt <ehaupt@critical.ch> wrote: > > Dan Langille <dan@langille.org> wrote: >>> On Aug 30, 2017, at 4:36 PM, Jan Beich <jbeich@FreeBSD.org> wrote: >>> >>> Dan Langille <dvl@FreeBSD.org> writes: >>> >>>> Author: dvl >>>> Date: Wed Aug 30 19:32:00 2017 >>>> New Revision: 448998 >>>> URL: https://svnweb.freebsd.org/changeset/ports/448998 >>>> >>>> Log: >>>> Add base/port options for libpcap >>> [...] >>>> +OPTIONS_DEFINE= LIBPCAP_BASE LIBPCAP_PORTS >>> [...] >>>> +OPTIONS_SINGLE= SG1 >>>> +OPTIONS_SINGLE= LIBPCAP_BASE LIBPCAP_PORTS >>> >>> _SINGLE declares a group of options, not the option themselves. >>> When _SINGLE is overloaded by _DEFINE the option is no longer >>> exclusive. >>> >>> Did you forget to adjust Porter's Handbook example? >> >> So it seems, thank you. >> >>> OPTIONS_SINGLE= LIBPCAP >>> OPTIONS_SINGLE_LIBPCAP= LIBPCAP_BASE LIBPCAP_PORTS >>> >>>> +OPTIONS_DEFAULT= LIBPCAP_BASE >>> >>> Doesn't work if net/libpcap is installed as a dependency by another >>> (unrelated) port. >> >> What do you mean by doesn't work? >> >> tcpreplay will work. It will use the lib in base, and ignore the lib >> provided by net/libpcap >> >> Do I misunderstand? >> >>> +LIBPCAP_PORTS_BUILD_DEPENDS= >>> ${LOCALBASE}/lib/libpcap.a:net/libpcap >>>> +LIBPCAP_PORTS_LIB_DEPENDS= libpcap.so:net/libpcap >>> >>> Maybe drop _BUILD_DEPENDS hack by adding .1 suffix to _LIB_DEPENDS. >> >> I don't understand the .1 - did i miss another handbook item? > > I'm committing a patch shortly to address those issues. Thank you. -- Dan Langille - BSDCan / PGCon dan@langille.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7662236E-0981-4BB7-9D23-A95CCC51ED9D>