From owner-dev-commits-src-all@freebsd.org Thu May 13 15:54:07 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E43C64637F; Thu, 13 May 2021 15:54:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fgx6R2jfVz3MTL; Thu, 13 May 2021 15:54:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4FF3F217B4; Thu, 13 May 2021 15:54:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 14DFs76P053531; Thu, 13 May 2021 15:54:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 14DFs79n053530; Thu, 13 May 2021 15:54:07 GMT (envelope-from git) Date: Thu, 13 May 2021 15:54:07 GMT Message-Id: <202105131554.14DFs79n053530@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lutz Donnerhacke Subject: git: 9674c2e68c61 - main - netgraph/ng_bridge: become SMP aware MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: donner X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9674c2e68c613757ddf5a8780743842b5ac4d74f Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2021 15:54:07 -0000 The branch main has been updated by donner: URL: https://cgit.FreeBSD.org/src/commit/?id=9674c2e68c613757ddf5a8780743842b5ac4d74f commit 9674c2e68c613757ddf5a8780743842b5ac4d74f Author: Lutz Donnerhacke AuthorDate: 2021-01-12 21:28:29 +0000 Commit: Lutz Donnerhacke CommitDate: 2021-05-13 15:53:07 +0000 netgraph/ng_bridge: become SMP aware The node ng_bridge underwent a lot of changes in the last few months. All those steps were necessary to distinguish between structure modifying and read-only data transport paths. Now it's done, the node can perform frame forwarding on multiple cores in parallel. MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D28123 --- sys/netgraph/ng_bridge.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sys/netgraph/ng_bridge.c b/sys/netgraph/ng_bridge.c index ecb00f9ba29f..470c0f05f18d 100644 --- a/sys/netgraph/ng_bridge.c +++ b/sys/netgraph/ng_bridge.c @@ -351,15 +351,6 @@ ng_bridge_constructor(node_p node) priv->conf.minStableAge = DEFAULT_MIN_STABLE_AGE; priv->sendUnknown = 1; /* classic bridge */ - /* - * This node has all kinds of stuff that could be screwed by SMP. - * Until it gets it's own internal protection, we go through in - * single file. This could hurt a machine bridging between two - * GB ethernets so it should be fixed. - * When it's fixed the process SHOULD NOT SLEEP, spinlocks please! - * (and atomic ops ) - */ - NG_NODE_FORCE_WRITER(node); NG_NODE_SET_PRIVATE(node, priv); priv->node = node;