From owner-freebsd-threads@FreeBSD.ORG  Thu Feb 12 11:29:41 2004
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1BD0816A4CE; Thu, 12 Feb 2004 11:29:41 -0800 (PST)
Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B849143D1D; Thu, 12 Feb 2004 11:29:40 -0800 (PST)
	(envelope-from eischen@vigrid.com)
Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4])
	by mail.pcnet.com (8.12.10/8.12.1) with ESMTP id i1CJTNfo011717;
	Thu, 12 Feb 2004 14:29:23 -0500 (EST)
Date: Thu, 12 Feb 2004 14:29:23 -0500 (EST)
From: Daniel Eischen <eischen@vigrid.com>
X-Sender: eischen@pcnet5.pcnet.com
To: Julian Elischer <julian@elischer.org>
In-Reply-To: <Pine.BSF.4.21.0402121102570.10555-100000@InterJet.elischer.org>
Message-ID: <Pine.GSO.4.10.10402121418450.5277-100000@pcnet5.pcnet.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: scottl@freebsd.org
cc: freebsd-threads@freebsd.org
Subject: Re: Should ps -p list threads?
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 19:29:41 -0000

On Thu, 12 Feb 2004, Julian Elischer wrote:
> 
> The origianlpatch had _H show threads and normal ps did not..
> I don't know why this is as it is...

Because it didn't take into account other 'ps' options.  Enabling
or disabling thread info should be an option for all KERN_PROC_foo,
not a separate option.  If I were to change it, I would add

	#define	KERN_PROC_THREADS	0x10000

to <sys/sysctl.h>.  Then allow:

	mib[0] = CTL_KERN;
	mib[1] = KERN_PROC;
	mib[2] = KERN_PROC_UID | KERN_PROC_THREADS;
	mib[3] = pid;

...

-- 
Dan Eischen