From owner-freebsd-geom@FreeBSD.ORG Wed Oct 19 16:37:35 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B63D1065740; Wed, 19 Oct 2011 16:37:35 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id CD7FE8FC17; Wed, 19 Oct 2011 16:37:34 +0000 (UTC) Received: by vcbfo13 with SMTP id fo13so2581776vcb.13 for ; Wed, 19 Oct 2011 09:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=+pmuQ6zXwytpYZjcJ9W5UaJjOKFK/fH5C09DlGS3Tko=; b=Xdw7WJ2q5oyplHklC7E6RZvNoy7f0fcTV9s2+BTaqqBBYPr+S0a5rbz1bkw9iOOB3u HIuLzOmfA1thC0qeySm2JGUK7OigrPEY+Z4EV2i1daEXSymlpkmO1F7rF7Q8X9b3OxTx xhuzgbVpfBKgX3EYM62kLLsZtY/2ySzuAR9eM= MIME-Version: 1.0 Received: by 10.182.111.70 with SMTP id ig6mr1118973obb.6.1319042254074; Wed, 19 Oct 2011 09:37:34 -0700 (PDT) Received: by 10.182.122.33 with HTTP; Wed, 19 Oct 2011 09:37:33 -0700 (PDT) In-Reply-To: <20111019161833.GB1982@garage.freebsd.pl> References: <924643A0-0798-4FAC-8F82-4AFBC56DC8D7@gmail.com> <7EC93C28-6405-443F-92C6-0291F8D88995@gmail.com> <20111017132945.GG1679@garage.freebsd.pl> <20111019161833.GB1982@garage.freebsd.pl> Date: Wed, 19 Oct 2011 09:37:33 -0700 Message-ID: From: Garrett Cooper To: Pawel Jakub Dawidek Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Xin LI , freebsd-geom@freebsd.org Subject: Re: GELI devices produced with 9.0+ fail when mounted on 8.2, etc? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2011 16:37:35 -0000 On Wed, Oct 19, 2011 at 9:18 AM, Pawel Jakub Dawidek wrot= e: > On Wed, Oct 19, 2011 at 08:30:39AM -0700, Garrett Cooper wrote: >> Patch added for the first suggestion here: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D161807 . I'll see if I can >> get around to the other two sometime before the end of the week. > > I'm already working on this. Unfortunately 'upgrade' subcommand will be > much harder to implement, because in some cases we would need to rewrite > the data for the entire provider. I decided not to add upgrade. It also > doesn't buy us much. Even after upgrade you cannot switch to new > algorithms or to multi-key encryption, etc. > > Instead I added 'version' subcommand: > > =A0 =A0 =A0 =A0geli version [-l] > =A0 =A0 =A0 =A0geli version [prov ...] > > Examples: > > =A0 =A0 =A0 =A0# geli version > =A0 =A0 =A0 =A0kernel: 6 > =A0 =A0 =A0 =A0userland: 5 > > =A0 =A0 =A0 =A0# geli version ada0 gpt/secret > =A0 =A0 =A0 =A0ada0: 5 > =A0 =A0 =A0 =A0gpt/secret: 3 > > =A0 =A0 =A0 =A0# geli version -l > =A0 =A0 =A0 =A0FreeBSD version: highest supported GELI version: > =A0 =A0 =A0 =A0FreeBSD 6.0: 0 > =A0 =A0 =A0 =A0FreeBSD 6.1: 0 > =A0 =A0 =A0 =A0FreeBSD 6.2: 3 > =A0 =A0 =A0 =A0FreeBSD 6.3: 3 > =A0 =A0 =A0 =A0FreeBSD 6.4: 3 > =A0 =A0 =A0 =A0FreeBSD 7.0: 3 > =A0 =A0 =A0 =A0FreeBSD 7.1: 3 > =A0 =A0 =A0 =A0FreeBSD 7.2: 3 > =A0 =A0 =A0 =A0FreeBSD 7.3: 3 > =A0 =A0 =A0 =A0FreeBSD 7.4: 3 > =A0 =A0 =A0 =A0FreeBSD 8.0: 3 > =A0 =A0 =A0 =A0FreeBSD 8.1: 3 > =A0 =A0 =A0 =A0FreeBSD 8.2: 5 > =A0 =A0 =A0 =A0FreeBSD 9.0: 6 Wouldn't it be better to document this in a manpage like I suggested so the code could be MFCed easier? Also, I like the thought of having a separate subcommand -- version -- for displaying the version output of a geli image. It seems like: geli upgrade md0 should just upgrade md0 to the latest supported metadata format instead of printing out the metadata version, as the implied metadata version should be the latest one by default. Thanks, -Garrett