From nobody Tue Aug 22 23:59:40 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVmYQ4vD2z4qdyv for ; Tue, 22 Aug 2023 23:59:54 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVmYP53kjz4YNX for ; Tue, 22 Aug 2023 23:59:53 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; dkim=none ("invalid DKIM record") header.d=kev009.com header.s=google header.b=NIPY7OOy; spf=pass (mx1.freebsd.org: domain of kevin.bowling@kev009.com designates 2607:f8b0:4864:20::235 as permitted sender) smtp.mailfrom=kevin.bowling@kev009.com; dmarc=none Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3a85cc7304fso1707169b6e.1 for ; Tue, 22 Aug 2023 16:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1692748792; x=1693353592; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qf4+6OSa4ZzODy9D2XgA1IA+oKFEofk81Da8CfSjyn4=; b=NIPY7OOyFnidGmZQu08yk4mCiXw35bZXS+kqfLKvji1mLyLzFFsE9FZ+XnRk9RllFr hjla0UEzcYEqlNhizfBusZFO28UR21ltifGmyactZuszuuQcXMw1WtPHrA0VsEe0RGUm 2SHsWGXYN6X3KpeihvaQ1FL5t/UKSqA3McVkw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692748792; x=1693353592; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qf4+6OSa4ZzODy9D2XgA1IA+oKFEofk81Da8CfSjyn4=; b=THdXmxhS9Ck/LwloPvqSwkrrtvKmtGt6gaSHuhBEtcAZ+75ClaErSHW+QhA7LhjCWD Y+Y624Dbz4t+YSWhaKa6VolmzEs8gvY4wATQKJEB+xx32VUzVjqjEHxYrPrpr1KmjXPf 0qG0vsy6xYe9wltXHwqVgM1Yw26tSg740t2VUfraG1whWZFieV2teE7dsrmvAn7wkRNw ivornGAxQCJG7MXsy/G/neznmBWEzDDpmNmWd9gEiheDcUHfsxmybCxfejDjDKMQhP1i Drs3MPxd0m7Bs+GVXWrbkoP29AquoOBlvjrVAnmZCXmKTmySBNHqKtMGtl3znk5NPX1L jLrw== X-Gm-Message-State: AOJu0YzF3K5aydkYzfsUhcWc8OFoopAshSYR/3Hzheb4hrWRnXAeedOs h3H8wSZx4gyh40LA9bHtZ4FoWn2ZZx9ARxRa3EnqBA== X-Google-Smtp-Source: AGHT+IF0+VHyIoPJWAeumx5vgOhziTTnc43Hyk0tGCrWYiAoZBIoaPG+oDXFRyBMSgR3p5uMsECdFYrLUL60xWF6N5M= X-Received: by 2002:a05:6808:ec7:b0:3a7:5d83:14d2 with SMTP id q7-20020a0568080ec700b003a75d8314d2mr15144667oiv.17.1692748792233; Tue, 22 Aug 2023 16:59:52 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> In-Reply-To: From: Kevin Bowling Date: Tue, 22 Aug 2023 16:59:40 -0700 Message-ID: Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor To: Kristof Provost Cc: Sumit Saxena , Warner Losh , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.28 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; NEURAL_HAM_LONG(-0.98)[-0.980]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_PERMFAIL(0.00)[kev009.com:s=google]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::235:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[kev009.com:~]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; DMARC_NA(0.00)[kev009.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Spamd-Bar: --- X-Rspamd-Queue-Id: 4RVmYP53kjz4YNX On Tue, Aug 22, 2023 at 3:39=E2=80=AFPM Kevin Bowling wrote: > > > > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost wrote: >> >> On 27 Jun 2023, at 11:17, Kristof Provost wrote: >> >> On 4 Nov 2022, at 23:55, Warner Losh wrote: >> >> The branch main has been updated by imp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc786= 1020dc3a2a2d717 >> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >> Author: Sumit Saxena >> AuthorDate: 2022-11-04 22:24:32 +0000 >> Commit: Warner Losh >> CommitDate: 2022-11-04 22:24:32 +0000 >> >> if_bnxt: Add support for VLAN on Thor >> >> Reviewed by: imp >> Differential Revision: https://reviews.freebsd.org/D36443 >> --- >> sys/dev/bnxt/bnxt.h | 3 +- >> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------------= ------ >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >> sys/dev/bnxt/if_bnxt.c | 7 ++- >> 4 files changed, 74 insertions(+), 53 deletions(-) >> >> This commit appears to have broken vlan on these interfaces. >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a= Dell T640, if that helps). >> >> A simple vlan creation on top of one: >> ifconfig vlan create >> ifconfig vlan0 vlan 201 vlandev bnxt0 >> >> Results in a loss of connectivity. The kernel logs this, which I assume = is related: >> >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.` >> >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I ca= n create vlan interfaces on top of bnxt0 without losing connectivity. >> >> >> Should we revert this before 14.0? >> >> There=E2=80=99s also a report of what I think is the same issue in https= ://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133 >> >> There=E2=80=99s a proposed patch there, but it did not work for me. > > > In markj=E2=80=99s analysis he mentions the issue of the reinit. > > It sounds like there are multiple bugs in this driver but one quick band = aid may be to mark the driver as not needing re-init for VLAN modifications= .. that sounds unlikely and was probably an accident when the if reset func= tionality was added. You can check e1000 for that. Here's what I mean as a patch https://reviews.freebsd.org/D41558 > Note I don=E2=80=99t have this hw and haven=E2=80=99t audited the code so= this could be noise but it=E2=80=99s an easy thing to check. > >> Best regards, >> Kristof