From owner-svn-src-head@freebsd.org Wed May 9 19:08:01 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6853EFC8B7F; Wed, 9 May 2018 19:08:01 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9496173047; Wed, 9 May 2018 19:08:00 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id GURKfMjyCuYopGURLf4JRC; Wed, 09 May 2018 13:07:52 -0600 X-Authority-Analysis: v=2.3 cv=GopsBH9C c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=VUJBJC2UJ8kA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=nvwLtNBOv7apgak8wIsA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 2EAF732E; Wed, 9 May 2018 12:07:50 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w49J7YxG003672; Wed, 9 May 2018 12:07:34 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w49J7Y0L003669; Wed, 9 May 2018 12:07:34 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201805091907.w49J7Y0L003669@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: John Baldwin cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet In-Reply-To: Message from John Baldwin of "Wed, 09 May 2018 07:58:14 -0700." <4065288.o9QKfFzp22@ralph.baldwin.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 09 May 2018 12:07:34 -0700 X-CMAE-Envelope: MS4wfGcJX3ojBLJZMrpCKBJ71eR+X99Aphm6RSxt+PE9MykEfd3VnrPPMxp/o1wOznEf20/Mm6snfbsqgXhOYsD+A+EMNF11zewhGFAquy7en+T4BJXhK1OZ jE2NC8HcJW3ToQlcuH2iBCCCSi+XABweidW8zA4ysuycQfZEym+iS2C8fBF7MksjcCaS1lXPFc98wYBDxOzm6MxxMqEo1W4fY+w5GCUx/ZjV4rHeeP2fB2PJ u1RudVMen/8NDLAXJggwEoYuMw+/3PwOsmBnC8PDGhpemvomApm7o7T8R7dNusxDJwGi+3m/t2WslxWHC6GwUzLcf1hupe05jnPsiBGKsNo= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 19:08:01 -0000 In message <4065288.o9QKfFzp22@ralph.baldwin.cx>, John Baldwin writes: > On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote: > > Author: cy > > Date: Wed May 9 02:07:09 2018 > > New Revision: 333393 > > URL: https://svnweb.freebsd.org/changeset/base/333393 > > > > Log: > > Document intentional fallthrough. (CID 976535) > > > > MFC after: 1 week > > > > Modified: > > head/sys/contrib/ipfilter/netinet/fil.c > > > > Modified: head/sys/contrib/ipfilter/netinet/fil.c > > =========================================================================== > === > > --- head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:02:58 2018 > (r333392) > > +++ head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:07:09 2018 > (r333393) > > @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin) > > } > > } > > #endif > > + /* fallthrough is intentional */ > > case ICMP_SOURCEQUENCH : > > case ICMP_REDIRECT : > > case ICMP_TIMXCEED : > > Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are > three other instances of that style in ipfilter already (and none others > using this comment style). Thanks John. It's been fixed in r333393. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.