From owner-svn-src-all@freebsd.org Fri Aug 18 07:21:39 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5BEADDCF51E; Fri, 18 Aug 2017 07:21:39 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 18AE17681F; Fri, 18 Aug 2017 07:21:37 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA20029; Fri, 18 Aug 2017 10:21:30 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1dibb0-000JJl-6j; Fri, 18 Aug 2017 10:21:30 +0300 Subject: Re: svn commit: r322601 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys To: John Baldwin References: <201708162340.v7GNeWrL098164@repo.freebsd.org> <4786e0df-cbbd-d0fe-2e45-682b9fe24652@FreeBSD.org> <1870652.QF6rqaG5fn@ralph.baldwin.cx> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org From: Andriy Gapon Message-ID: Date: Fri, 18 Aug 2017 10:20:37 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1870652.QF6rqaG5fn@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Aug 2017 07:21:39 -0000 On 17/08/2017 20:07, John Baldwin wrote: > On Thursday, August 17, 2017 10:42:51 AM Andriy Gapon wrote: >> On 17/08/2017 02:40, John Baldwin wrote: >>> Author: jhb >>> Date: Wed Aug 16 23:40:32 2017 >>> New Revision: 322601 >>> URL: https://svnweb.freebsd.org/changeset/base/322601 >>> >>> Log: >>> Mark ZFS ABD inline functions static. >>> >>> When built with -fno-inline-functions zfs.ko contains undefined references >>> to these functions if they are only marked inline. >>> >>> Reviewed by: avg (earlier version) >> >> I think that you rushed a little bit on this one: >> https://github.com/openzfs/openzfs/pull/444 >> >> But no big deal, it will be easy to merge once the upstream wakes up :-) > > Oof, I thought you had previously ok'd to commit this? (I just hadn't gotten > around to it.) My apologies for misunderstanding. I think I did. It's good to have a fix sooner rather than later even if it's not a final version. Thanks! -- Andriy Gapon