From nobody Fri Jun 5 21:50:58 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gXFVq4CgJz6gblM for ; Fri, 05 Jun 2026 21:50:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gXFVq103zz3V3C for ; Fri, 05 Jun 2026 21:50:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780696259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=868x8cag/CON1A4x7T4UyLLiV5opnp2emfam0HlmUtM=; b=jsj/tEMMmUy0v/G5KMVjDamedfL3+0UurW6H6i4KNjPa6vloxpFZLw/JhkRe8vny5S63b3 pKRuW79Gc80fQv1sgF+bngqAQ9XMoIkKp0tjWgQGDj7+47jk0IWN/z3569L0sQdR9CKd0V jYd+e2QplPYYsCiQq8hkT+LvqqK4WitKciynzKs38M7iKWmKNSpZTEB6NJapLvw2Tj+Ngv qq8yJ0+G+gdVHv07aV/Do2pzk72mx7kQZxgZVFgIgJTtumz2MpUFzJEe0Phz0iBZfStnHU STykKI5LroSsy2TYbI7YMQtudIwrfm322q0OMbk7HQ7w2V0XvJ8kykUyQwyUnA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780696259; a=rsa-sha256; cv=none; b=PX2DomXMkTY2FjljUA1Xy6Lja80tXU8t2G5ETBhPUnK/wF7Q7UrHq9YGuxSdDCmUTTrI/v pWgberLZmouYIvKi39GN+kAd+dn1CjVqBMZE23BYqa82QlOQU0IF58MtnmohONxz7MocQK KOMUawHzrBWC45t+nYlOm6k+Jo6iAFCa8fZMAPvZ7bfTKnGbs7iM+wqRF5rUOCN8w75lmP uFW8qPH5feqo0eR4/jOw2vLdYBuS/lDf8lpYv7Wk/dV1riaXY2C8Ttq6c0PMClNwVoG1g+ euWtuTnsQWGG8vG+uGg7EigM+nGUP8OSVuPOKA3xboTZdVzuNeCK6PecoC6QTw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780696259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=868x8cag/CON1A4x7T4UyLLiV5opnp2emfam0HlmUtM=; b=HkbsOfdQiWmZ8Llwtuy0yao30yDXRyY69nm3USGum/EKeR0xa7BQUWl2v3cbQ/NuMAz1IT ZnpEoltQWpSniBbChvPxo6L3iyxlwY5hPRt+wjUbOFOs5KFzHKD7tS/uE5uWiZdE2KkkiI Tw3N01JXHF5xo/pwaCoeshdwG2cxMgHHq/7ole0sKUd2a9iVTd1Geg2zl64b+/Hy0U0qIU sNXxyehLUgcYZjD6pUBJtJAswhrg543+1dRuexJiKTKy1yPrnqC4j1MBVGxal3aXXlDgH6 OPALjmuMWIGqAQFSButryGUZUJ2kIqxSNRVoq2OHsJyJ8eBFp/SBdDnemZClMg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gXFVq02gRznx4 for ; Fri, 05 Jun 2026 21:50:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1a931 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 05 Jun 2026 21:50:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 77e894cb09af - main - audit: Replace TAILQ with STAILQ List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 77e894cb09affe828f4bc81b8e4751a7e22860de Auto-Submitted: auto-generated Date: Fri, 05 Jun 2026 21:50:58 +0000 Message-Id: <6a2344c2.1a931.6e903b99@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=77e894cb09affe828f4bc81b8e4751a7e22860de commit 77e894cb09affe828f4bc81b8e4751a7e22860de Author: Dag-Erling Smørgrav AuthorDate: 2026-06-05 21:50:46 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-06-05 21:50:46 +0000 audit: Replace TAILQ with STAILQ This reduces the size of a trigger entry from 24 bytes to 16 (or from 12 bytes to 8 on 32-bit) with no additional complexity. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans, emaste Differential Revision: https://reviews.freebsd.org/D57464 --- sys/security/audit/audit_trigger.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sys/security/audit/audit_trigger.c b/sys/security/audit/audit_trigger.c index e2520292cc5d..b7ed68f73363 100644 --- a/sys/security/audit/audit_trigger.c +++ b/sys/security/audit/audit_trigger.c @@ -50,13 +50,13 @@ */ struct trigger_info { unsigned int trigger; - TAILQ_ENTRY(trigger_info) list; + STAILQ_ENTRY(trigger_info) list; }; static MALLOC_DEFINE(M_AUDITTRIGGER, "audit_trigger", "Audit trigger events"); static struct cdev *audit_dev; static int audit_isopen = 0; -static TAILQ_HEAD(, trigger_info) trigger_list; +static STAILQ_HEAD(, trigger_info) trigger_list; static struct mtx audit_trigger_mtx; static struct selinfo audit_trigger_rsel; @@ -85,9 +85,9 @@ audit_close(struct cdev *dev, int fflag, int devtype, struct thread *td) /* Flush the queue of pending trigger events. */ mtx_lock(&audit_trigger_mtx); audit_isopen = 0; - while (!TAILQ_EMPTY(&trigger_list)) { - ti = TAILQ_FIRST(&trigger_list); - TAILQ_REMOVE(&trigger_list, ti, list); + while (!STAILQ_EMPTY(&trigger_list)) { + ti = STAILQ_FIRST(&trigger_list); + STAILQ_REMOVE_HEAD(&trigger_list, list); free(ti, M_AUDITTRIGGER); } mtx_unlock(&audit_trigger_mtx); @@ -102,15 +102,15 @@ audit_read(struct cdev *dev, struct uio *uio, int ioflag) struct trigger_info *ti = NULL; mtx_lock(&audit_trigger_mtx); - while (TAILQ_EMPTY(&trigger_list)) { + while (STAILQ_EMPTY(&trigger_list)) { error = msleep(&trigger_list, &audit_trigger_mtx, PSOCK | PCATCH, "auditd", 0); if (error) break; } if (!error) { - ti = TAILQ_FIRST(&trigger_list); - TAILQ_REMOVE(&trigger_list, ti, list); + ti = STAILQ_FIRST(&trigger_list); + STAILQ_REMOVE_HEAD(&trigger_list, list); } mtx_unlock(&audit_trigger_mtx); if (!error) { @@ -135,7 +135,7 @@ audit_poll(struct cdev *dev, int events, struct thread *td) if (events & (POLLIN | POLLRDNORM)) { mtx_lock(&audit_trigger_mtx); - if (!TAILQ_EMPTY(&trigger_list)) + if (!STAILQ_EMPTY(&trigger_list)) revents = events & (POLLIN | POLLRDNORM); else selrecord(td, &audit_trigger_rsel); @@ -158,7 +158,7 @@ audit_send_trigger(unsigned int trigger) return (ENODEV); } ti->trigger = trigger; - TAILQ_INSERT_TAIL(&trigger_list, ti, list); + STAILQ_INSERT_TAIL(&trigger_list, ti, list); selwakeup(&audit_trigger_rsel); wakeup(&trigger_list); mtx_unlock(&audit_trigger_mtx); @@ -179,7 +179,7 @@ void audit_trigger_init(void) { - TAILQ_INIT(&trigger_list); + STAILQ_INIT(&trigger_list); mtx_init(&audit_trigger_mtx, "audit_trigger_mtx", NULL, MTX_DEF); }