From owner-svn-ports-all@FreeBSD.ORG Mon May 6 23:11:04 2013 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D4985730; Mon, 6 May 2013 23:11:04 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Received: from mx.critical.ch (mx.critical.ch [62.2.45.171]) by mx1.freebsd.org (Postfix) with ESMTP id 73244E67; Mon, 6 May 2013 23:11:04 +0000 (UTC) Received: from beaver.home.critical.ch (84-75-192-66.dclient.hispeed.ch [84.75.192.66]) (authenticated bits=0) by mx.critical.ch (8.14.5/8.14.5/critical-1.0) with ESMTP id r46NB2Dv094420; Tue, 7 May 2013 01:11:03 +0200 (CEST) (envelope-from ehaupt@FreeBSD.org) Date: Tue, 7 May 2013 01:11:02 +0200 From: Emanuel Haupt To: mva@FreeBSD.org Subject: Re: svn commit: r317551 - head/print/pslib Message-Id: <20130507011102.1fc817d328fafa8fa5affbe8@FreeBSD.org> In-Reply-To: <201305062153.r46Lru8L082513@svn.freebsd.org> References: <201305062153.r46Lru8L082513@svn.freebsd.org> X-Mailer: Sylpheed 3.3.0 (GTK+ 2.24.17; amd64-portbld-freebsd9.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2013 23:11:04 -0000 Emanuel Haupt wrote: > Author: ehaupt > Date: Mon May 6 21:53:56 2013 > New Revision: 317551 > URL: http://svnweb.freebsd.org/changeset/ports/317551 > > Log: > Remove USE_GETTEXT leftover. > > Approved by: portmgr (bapt) > > Modified: > head/print/pslib/Makefile > > Modified: head/print/pslib/Makefile > ============================================================================== > --- head/print/pslib/Makefile Mon May 6 21:34:57 2013 > (r317550) +++ head/print/pslib/Makefile Mon May 6 21:53:56 > 2013 (r317551) @@ -47,7 +47,6 @@ CONFIGURE_ENV+= > ac_cv_prog_DOC_TO_MAN="" .endif > > .if ${PORT_OPTIONS:MNLS} > -USE_GETTEXT= yes > PLIST_SUB+= NLS="" > .else > CONFIGURE_ENV+= ac_cv_header_libintl_h=no > Even better: There is no need for bsd.port.pre.mk. We can use bsd.port.options.mk and conditionalze gettext but we have to handle MAN3!= ${CAT} ${FILESDIR}/man3 differently. Please consider the following patch: http://people.freebsd.org/~ehaupt/patches/pslib.patch