From owner-svn-src-head@freebsd.org Wed Jan 17 08:24:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8438FEB587B; Wed, 17 Jan 2018 08:24:34 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0781D833E0; Wed, 17 Jan 2018 08:24:33 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from freyja.zeit4.iv.bundesimmobilien.de ([87.138.105.249]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M5tU1-1emfM81rnl-00xw9Q; Wed, 17 Jan 2018 09:24:25 +0100 Date: Wed, 17 Jan 2018 09:24:18 +0100 From: "O. Hartmann" To: Kirk McKusick Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328075 - head/sbin/fsck_ffs Message-ID: <20180117092418.2d823f60@freyja.zeit4.iv.bundesimmobilien.de> In-Reply-To: <201801170631.w0H6VLBP005425@repo.freebsd.org> References: <201801170631.w0H6VLBP005425@repo.freebsd.org> Organization: Walstatt MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JxzyXiPwqUl5KFdS5LVGg4dpkl014Ls+gvzQXmjIQu/r7IninqX q3/lhhCXqAFtC08lfVfPJh4Oaibp2nbnMKA6OBfOY4HCrxT/DP1kRZjCLqAB/coAzKEW+4+ XzN3ngKuoq22+Lg9Vp1rDaq++MpoaVEBP9MbjISWkC6mYeRT6qXpu/rm2No+gmXlqQq3DcO c43GNI1JdI+SajDJgD0mg== X-UI-Out-Filterresults: notjunk:1;V01:K0:4dxCAViSw/A=:GL57mT/i6EvTiku9b1J41n ffOW2kqmobm2bP0hf7n2fVc2+ZrDmqqReo4IhtB41b/U2YYM0lzpivHZ3EBnz6ntuPns42EC8 KruBgR+zlISej+AeexYL9l1+t94ThXIocNcZusy/LAKGm6PzQS4rmaBn4ol284VJjuPL5tBDs uJZTfSM/hxgQgmDKONI7I3O6m4a8SZ5XyIFNMG4cMhmaJc1TenuIsvgDuikqPo0tUnoh0D5/1 NvLZ1WHScaV9bB+bD+AqgizCW1qvAO8/TYCCeivLtljJvhaieIFvl5BH1L5a8pVW7fiesZxdZ P0JrT+miiZYcfTB/jMZb6MbOztasvYfiaj3+QuiCvmx3UxLHQ+zvh2xUOj9eoEVKxYiD4sU6V jRCuUprHxFoUGBR1+yEaZBYXeweVQjpDFJPtcmXs7dKmvO0Q+M1PCcZW0ZkaAOmkB4G7VxO7+ OcRDEM2Pa7g5fj4HKVcuK9tpHlWkCwbTKKVE+c/HJPLSykt2xxjvlzLihIKh5I0SKkjg41ssd DyDBhD0+1YBovoaoqYtB23zhXCgOZpAxRIni3+0uXssyvlPOi5GC9wMaiCfo3OwZW5iM/5CEU XF2OK/pRMNGFUSEEBl6AodT2F97PuParSSLL8tKZh5FU4oPJbNilZH0U3kif9rVbo7D9/sQgo egNds4rPChMuKpMdyS6AQTswhHlSiNErwaioZeV0qVk6tDlW1xBkG9CtnIiOwT/BEpZ8QApnY rhHPn+TJuNkpXpa/C04k1iLR2ZeEBiDX6h2sB/j7CsVFmjncISS52DUhpb0hqoY+BY/AFc+QC 3AtW5TN614/YzaPyyhoPLVZDa8kTg+0yIIs2jS//CggKgPXfNo= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 08:24:34 -0000 On Wed, 17 Jan 2018 06:31:21 +0000 (UTC) Kirk McKusick wrote: > Author: mckusick > Date: Wed Jan 17 06:31:21 2018 > New Revision: 328075 > URL: https://svnweb.freebsd.org/changeset/base/328075 > > Log: > Rename cgget => cglookup to clear name space for new libufs function cgget. > No functional change. > > Modified: > head/sbin/fsck_ffs/fsck.h > head/sbin/fsck_ffs/fsutil.c > head/sbin/fsck_ffs/inode.c > head/sbin/fsck_ffs/pass1.c > head/sbin/fsck_ffs/pass5.c > > Modified: head/sbin/fsck_ffs/fsck.h > ============================================================================== > --- head/sbin/fsck_ffs/fsck.h Wed Jan 17 06:22:10 2018 (r328074) > +++ head/sbin/fsck_ffs/fsck.h Wed Jan 17 06:31:21 2018 (r328075) > @@ -437,7 +437,7 @@ void freeinodebuf(void); > void fsutilinit(void); > int ftypeok(union dinode *dp); > void getblk(struct bufarea *bp, ufs2_daddr_t blk, long size); > -struct bufarea *cgget(int cg); > +struct bufarea *cglookup(int cg); > struct bufarea *getdatablk(ufs2_daddr_t blkno, long size, int type); > struct inoinfo *getinoinfo(ino_t inumber); > union dinode *getnextinode(ino_t inumber, int rebuildcg); > > Modified: head/sbin/fsck_ffs/fsutil.c > ============================================================================== > --- head/sbin/fsck_ffs/fsutil.c Wed Jan 17 06:22:10 2018 > (r328074) +++ head/sbin/fsck_ffs/fsutil.c Wed Jan 17 06:31:21 > 2018 (r328075) @@ -222,7 +222,7 @@ static struct bufarea > *cgbufs; /* header for cylinder static int > flushtries; /* number of tries to reclaim memory */ > struct bufarea * > -cgget(int cg) > +cglookup(int cg) > { > struct bufarea *cgbp; > struct cg *cgp; > @@ -791,7 +791,7 @@ allocblk(long frags) > continue; > } > cg = dtog(&sblock, i + j); > - cgbp = cgget(cg); > + cgbp = cglookup(cg); > cgp = cgbp->b_un.b_cg; > if (!check_cgmagic(cg, cgbp)) > return (0); > > Modified: head/sbin/fsck_ffs/inode.c > ============================================================================== > --- head/sbin/fsck_ffs/inode.c Wed Jan 17 06:22:10 2018 > (r328074) +++ head/sbin/fsck_ffs/inode.c Wed Jan 17 06:31:21 > 2018 (r328075) @@ -673,7 +673,7 @@ allocino(ino_t request, int type) > if (ino == maxino) > return (0); > cg = ino_to_cg(&sblock, ino); > - cgbp = cgget(cg); > + cgbp = cglookup(cg); > cgp = cgbp->b_un.b_cg; > if (!check_cgmagic(cg, cgbp)) > return (0); > > Modified: head/sbin/fsck_ffs/pass1.c > ============================================================================== > --- head/sbin/fsck_ffs/pass1.c Wed Jan 17 06:22:10 2018 > (r328074) +++ head/sbin/fsck_ffs/pass1.c Wed Jan 17 06:31:21 > 2018 (r328075) @@ -98,7 +98,7 @@ pass1(void) > for (c = 0; c < sblock.fs_ncg; c++) { > inumber = c * sblock.fs_ipg; > setinodebuf(inumber); > - cgbp = cgget(c); > + cgbp = cglookup(c); > cgp = cgbp->b_un.b_cg; > rebuildcg = 0; > if (!check_cgmagic(c, cgbp)) > > Modified: head/sbin/fsck_ffs/pass5.c > ============================================================================== > --- head/sbin/fsck_ffs/pass5.c Wed Jan 17 06:22:10 2018 > (r328074) +++ head/sbin/fsck_ffs/pass5.c Wed Jan 17 06:31:21 > 2018 (r328075) @@ -174,7 +174,7 @@ pass5(void) > c * 100 / sblock.fs_ncg); > got_sigalarm = 0; > } > - cgbp = cgget(c); > + cgbp = cglookup(c); > cg = cgbp->b_un.b_cg; > if (!cg_chkmagic(cg)) > pfatal("CG %d: BAD MAGIC NUMBER\n", c); > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" This breaks buildworld for me: [...] ===> sbin/fsdb (all) --- all_subdir_rescue --- `pkill.o' is up to date. --- ps_make --- (cd /usr/src/rescue/rescue/../../bin/ps && make -DRESCUE CRUNCH_CFLAGS=-DRESCUE MK_AUTO_OBJ=yes DIRPRFX=rescue/rescue/ps/ fmt.o keyword.o nlist.o print.o ps.o) --- all_subdir_sbin --- Building /usr/obj/usr/src/amd64.amd64/sbin/fsdb/fsdb --- fsdb --- /usr/obj/usr/src/amd64.amd64/tmp/usr/bin/ld: error: undefined symbol: cgget >>> referenced by fsdb.c >>> fsdb.o:(findblk) cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [fsdb] Error code 1