From owner-cvs-all Wed Sep 5 8:13:47 2001 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 651CA37B406; Wed, 5 Sep 2001 08:13:41 -0700 (PDT) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.3) id RAA80096; Wed, 5 Sep 2001 17:13:31 +0200 (CEST) (envelope-from des@ofug.org) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch file.c References: <200109051222.f85CMS414529@freefall.freebsd.org> <20010905181734.B50064@nagual.pp.ru> From: Dag-Erling Smorgrav Date: 05 Sep 2001 17:13:31 +0200 In-Reply-To: <20010905181734.B50064@nagual.pp.ru> Message-ID: Lines: 14 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrey A. Chernov" writes: > > Use fseeko() instead of fseek() (u->offset is already an off_t), and mark > > some function arguments as unused. > Please don't forget to change lib/libfetch that way too. Please don't forget to make sense :) If you mean usr.bin/fetch/fetch.c, the fseek() there is redundant, and I've eliminated it in my latest patches (see the atomic fetch patch at http://people.freebsd.org/~des/software/) DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message