From owner-svn-src-all@freebsd.org Thu Sep 17 07:52:25 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C61FD9CE829; Thu, 17 Sep 2015 07:52:25 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (mail.turbocat.net [IPv6:2a01:4f8:d16:4514::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A7201A3E; Thu, 17 Sep 2015 07:52:25 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id ADB4E1FE023; Thu, 17 Sep 2015 09:52:23 +0200 (CEST) Subject: Re: svn commit: r287892 - head/sys/dev/usb/wlan To: Adrian Chadd References: <201509170301.t8H31KdP042687@repo.freebsd.org> <55FA6C62.6010705@selasky.org> <55FA6EA2.8050809@selasky.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Hans Petter Selasky Message-ID: <55FA7196.40004@selasky.org> Date: Thu, 17 Sep 2015 09:53:58 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 07:52:25 -0000 Hi Adrian, On 09/17/15 09:43, Adrian Chadd wrote: > .. I'm likely going to do exactly that as part of "making" if_rsu do > 11n and behave correctly. Right now it does neither. Thank you for helping out with the USB WLAN drivers. Yes, USB requests sleep and don't spin until they're done. > > But this is a pretty big design pattern flaw; all of the wifi drivers > use the usb library like this and .. well, unless you look under the > hood, you don't really realise that serialiser lock is being dropped > for you... :( Right. If you need any help test, code or review, let me know. Not dropping the mutex inside USB sleeping functions would force all USB drivers to use SX locks or lower in the locking hierherachy, for synchronization, which would not be so good. --HPS