From owner-cvs-all Sun Oct 20 8:35:17 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76EB537B401; Sun, 20 Oct 2002 08:35:16 -0700 (PDT) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8AEF643E9C; Sun, 20 Oct 2002 08:35:15 -0700 (PDT) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id BABCF534F; Sun, 20 Oct 2002 17:35:12 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Alfred Perlstein Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch common.c References: <200209202150.g8KLov9s006373@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: Sun, 20 Oct 2002 17:35:12 +0200 In-Reply-To: <200209202150.g8KLov9s006373@freefall.freebsd.org> (Alfred Perlstein's message of "Fri, 20 Sep 2002 14:50:57 -0700 (PDT)") Message-ID: Lines: 14 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2 (i386--freebsd) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Alfred Perlstein writes: > Log: > Fix an infinite loop when _fetch_read() can return 0 (if the > connection is broken), take this into account and return at this > point. This probably fixes the wrong bug: _fetch_read() shouldn't return 0. It currently does if it times out before reading anything (but not, as you say, if the connection is broken); it should return -1 instead, and your change to _fetch_getln() should be reverted. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message