From owner-svn-src-all@FreeBSD.ORG Sun Jan 18 14:49:30 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22A401065725 for ; Sun, 18 Jan 2009 14:49:29 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [78.110.53.255]) by mx1.freebsd.org (Postfix) with ESMTP id D99E58FC29 for ; Sun, 18 Jan 2009 14:49:28 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from DSPAM-Daemon (localhost [127.0.0.1]) by mx0.deglitch.com (Postfix) with SMTP id AF3D58FC4F for ; Sun, 18 Jan 2009 17:44:01 +0300 (MSK) Received: from orion.SpringDaemons.com (drsun1.dialup.corbina.ru [85.21.245.235]) by mx0.deglitch.com (Postfix) with ESMTPA id D93FD8FC18; Sun, 18 Jan 2009 17:43:59 +0300 (MSK) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id CBF4A398F3; Sun, 18 Jan 2009 17:44:02 +0300 (MSK) Date: Sun, 18 Jan 2009 17:43:57 +0300 From: Stanislav Sedov To: Kostik Belousov Message-Id: <20090118174357.3ed1459d.stas@FreeBSD.org> In-Reply-To: <20090118140644.GT48057@deviant.kiev.zoral.com.ua> References: <200901181404.n0IE4uXw075698@svn.freebsd.org> <20090118140644.GT48057@deviant.kiev.zoral.com.ua> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprint: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Sun Jan 18 17:44:01 2009 X-DSPAM-Confidence: 0.9899 X-DSPAM-Improbability: 1 in 9809 chance of being spam X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 49734031967003085517798 Cc: Stanislav Sedov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187395 - head/sys/gnu/fs/ext2fs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2009 14:49:30 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sun, 18 Jan 2009 16:06:44 +0200 Kostik Belousov mentioned: > > Please see a discussion on the fs@ and reasoning why I declined to commit > the similar patch. > I'm sorry I've missed that discussion entirely, but I can admit I had all the same concerns while reviewing the patch, and Alex's comments and Linux code reading made me fully confident that the modifications are safe and correct. Let me explain why I think so. The extra size added in inodes are used to store additional info like extended attributes, ACLs and so on. Each inode now has a field just after the legacy inode format struct that shows hom much additional space has been added to this particular inode. By analyzing this field the operating system can interpret additional data located in inode, if it understand its format (there might be application and/or OS specific data too). Our implementation just ignore this additional fields after sizeof(ext2fs_inode), both while reading and writing. Thus we don't interet this data yet we don't overwrite it. - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAklzQDIACgkQK/VZk+smlYE6TQCcCe7yDdJYU2cxYwiosHjYmK6s NT8An0+9Jom3CgHFhVy4PrvztjNXgpT9 =Cxan -----END PGP SIGNATURE----- !DSPAM:49734031967003085517798!