Date: Fri, 14 Apr 2017 14:10:56 -0700 From: Maxim Sobolev <sobomax@sippysoft.com> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Peter Wemm <peter@wemm.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Hiren Panchasara <hiren@freebsd.org> Subject: Re: svn commit: r316874 - head/sys/kern Message-ID: <CAH7qZfvPQpmTkypWdv1K=9yKF6was1sXuXY7McAeTrC8mvYZbg@mail.gmail.com> In-Reply-To: <513B1846-02E3-49E0-BAA2-CA923EDC5DFF@gmail.com> References: <201704141723.v3EHNS3B043902@repo.freebsd.org> <12133324.zHp9vo75vZ@overcee.wemm.org> <CAH7qZfuxM2pWvPh-LGP8_vrSpm==hTCWjnoZoXSvaFSgAaS8pg@mail.gmail.com> <6942092.OsECkgAp13@overcee.wemm.org> <513B1846-02E3-49E0-BAA2-CA923EDC5DFF@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a113f8c6cb4eaad054d26e0ee Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Peter, Ngie, Looks like out of that refactoring came a logical bug that is present in the head, which causes syslod to first to shutdown the socket for reading and then try to select/recv on it (which is somewhat stupid). And that issue has been masked by shutdown() on datagram socket becoming effectively a NOP in 11 & head 20 months ago. It only affects head though, 11-stable still has the old code which does not include that half-closed socket into the select list. Attached patch is expected to fix head, Peter, it would be nice if you can give it a try (restoring latest changes into uipc_sockets.c) and let me know if it helps. Thanks! On Fri, Apr 14, 2017 at 12:48 PM, Ngie Cooper (yaneurabeya) < yaneurabeya@gmail.com> wrote: > > > On Apr 14, 2017, at 12:46, Peter Wemm <peter@wemm.org> wrote: > > > > On Friday, April 14, 2017 12:41:52 PM Maxim Sobolev wrote: > >> Thanks, Peter. I will try to look into this asap. > > > > I don't understand what is going on yet. Presumably there must be other > > changes in play that affect udp/select sometime between the original 20= 15 > > change and this. The syslogd -s code is Old(TM). I'm also wondering > whether > > the -s code even works at all since the 2015 / r285910 change... > > syslogd has been refactored a lot on ^/head. I don=E2=80=99t think it=E2= =80=99s safe to > say that the ^/head and ^/stable/11 and earlier copies will function the > same. > Thanks, > -Ngie > --=20 Maksym Sobolyev Sippy Software, Inc. Internet Telephony (VoIP) Experts Tel (Canada): +1-778-783-0474 Tel (Toll-Free): +1-855-747-7779 Fax: +1-866-857-6942 Web: http://www.sippysoft.com MSN: sales@sippysoft.com Skype: SippySoft --001a113f8c6cb4eaad054d26e0ee Content-Type: text/plain; charset=US-ASCII; name="syslogd.diff" Content-Disposition: attachment; filename="syslogd.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j1ibuchu1 SW5kZXg6IHN5c2xvZ2QuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXNsb2dkLmMJKHJldmlzaW9uIDMxNjg1 NCkKKysrIHN5c2xvZ2QuYwkod29ya2luZyBjb3B5KQpAQCAtNzAyLDcgKzcwMiw3IEBACiAJCSAg ICBzaXplb2YoZmRfbWFzaykpOwogCiAJCVNUQUlMUV9GT1JFQUNIKHNsLCAmc2hlYWQsIG5leHQp IHsKLQkJCWlmIChzbC0+c2xfc29ja2V0ICE9IC0xKQorCQkJaWYgKHNsLT5zbF9zb2NrZXQgIT0g LTEgJiYgc2wtPnNsX3JlY3YgIT0gTlVMTCkKIAkJCQlGRF9TRVQoc2wtPnNsX3NvY2tldCwgZmRz cik7CiAJCX0KIAkJaSA9IHNlbGVjdChmZHNybWF4ICsgMSwgZmRzciwgTlVMTCwgTlVMTCwKQEAg LTI4NzcsNiArMjg3Nyw3IEBACiAJc3RydWN0IGFkZHJpbmZvIGhpbnRzLCAqcmVzLCAqcmVzMDsK IAlpbnQgZXJyb3I7CiAJY2hhciAqY3A7CisJaW50ICgqc2xfcmVjdikoc3RydWN0IHNvY2tsaXN0 ICopOwogCS8qCiAJICogV2UgaGF2ZSB0byBoYW5kbGUgdGhpcyBjYXNlIGZvciBiYWNrd2FyZHMg Y29tcGF0aWJpbGl0eToKIAkgKiBJZiB0aGVyZSBhcmUgdHdvIChvciBtb3JlKSBjb2xvbnMgYnV0 IG5vICdbJyBhbmQgJ10nLApAQCAtMzAwMyw2ICszMDA0LDcgQEAKIAkJfQogCQlkcHJpbnRmKCJu ZXcgc29ja2V0IGZkIGlzICVkXG4iLCBzKTsKIAkJbGlzdGVuKHMsIDUpOworCQlzbF9yZWN2ID0g c29ja2xpc3RfcmVjdl9zb2NrOwogCQlkcHJpbnRmKCJzaHV0ZG93blxuIik7CiAJCWlmIChTZWN1 cmVNb2RlIHx8IHJlcy0+YWlfZmFtaWx5ID09IEFGX0xPQ0FMKSB7CiAJCQkvKiBGb3JiaWQgY29t bXVuaWNhdGlvbiBpbiBzZWN1cmUgbW9kZS4gKi8KQEAgLTMwMTMsNiArMzAxNSw3IEBACiAJCQkJ CWRpZSgwKTsKIAkJCX0KIAkJCWRwcmludGYoImxpc3RlbmluZyBvbiBzb2NrZXRcbiIpOworCQkJ c2xfcmVjdiA9IE5VTEw7CiAJCX0gZWxzZQogCQkJZHByaW50Zigic2VuZGluZyBvbiBzb2NrZXRc biIpOwogCQlhZGRzb2NrKHJlcy0+YWlfYWRkciwgcmVzLT5haV9hZGRybGVuLApAQCAtMzAxOSw3 ICszMDIyLDcgQEAKIAkJICAgICYoc3RydWN0IHNvY2tsaXN0KXsKIAkJCS5zbF9zb2NrZXQgPSBz LAogCQkJLnNsX3BlZXIgPSBwZSwKLQkJCS5zbF9yZWN2ID0gc29ja2xpc3RfcmVjdl9zb2NrCisJ CQkuc2xfcmVjdiA9IHNsX3JlY3YKIAkJfSk7CiAJfQogCWZyZWVhZGRyaW5mbyhyZXMwKTsK --001a113f8c6cb4eaad054d26e0ee--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAH7qZfvPQpmTkypWdv1K=9yKF6was1sXuXY7McAeTrC8mvYZbg>