From owner-svn-src-head@FreeBSD.ORG Thu Nov 7 22:37:20 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F366A361; Thu, 7 Nov 2013 22:37:19 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C3B22239D; Thu, 7 Nov 2013 22:37:19 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VeYCU-000OCe-Uv; Thu, 07 Nov 2013 22:37:19 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id rA7MbF4w065361; Thu, 7 Nov 2013 15:37:16 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX181MWcxEn36tYHGTjY21M1g Subject: Re: svn commit: r257818 - in head/lib/msun: . src From: Ian Lepore To: Steve Kargl In-Reply-To: <20131107221308.GA61870@troutmask.apl.washington.edu> References: <201311072120.rA7LKY1J061512@svn.freebsd.org> <1383860529.31172.233.camel@revolution.hippie.lan> <20131107221308.GA61870@troutmask.apl.washington.edu> Content-Type: text/plain; charset="us-ascii" Date: Thu, 07 Nov 2013 15:37:15 -0700 Message-ID: <1383863835.31172.235.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Steve Kargl X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2013 22:37:20 -0000 On Thu, 2013-11-07 at 14:13 -0800, Steve Kargl wrote: > On Thu, Nov 07, 2013 at 02:42:09PM -0700, Ian Lepore wrote: > > On Thu, 2013-11-07 at 21:20 +0000, Steve Kargl wrote: > > > --- head/lib/msun/src/s_round.c Thu Nov 7 21:16:32 2013 (r257817) > > > +++ head/lib/msun/src/s_round.c Thu Nov 7 21:20:34 2013 (r257818) > > > @@ -52,3 +52,7 @@ round(double x) > > > return (-t); > > > } > > > } > > > + > > > +#if (LDBL_MANT_DIG == 53) > > > +__weak_reference(round, roundl); > > > +#endif > > > > I don't think that's a complete fix. I got a linker "undefined > > reference" error when testing your patch. I decided to make sure it > > wasn't a -DNO_CLEAN artifact and did a fresh build, and it just failed: > > > > I just can't win today. I forgot "#include " where > LDBL_MANT_DIG is defined. Can you try? > > Index: src/s_round.c > =================================================================== > --- src/s_round.c (revision 257818) > +++ src/s_round.c (working copy) > @@ -27,6 +27,8 @@ > #include > __FBSDID("$FreeBSD$"); > > +#include > + > #include "math.h" > #include "math_private.h" > That seems to have fixed things. Don't feel bad, I've got more tries in on the aicasm build thing and I still don't have it right. I supposedly learned my lesson about messing with build stuff 20 years ago, but I guess I'm getting a refresher. -- Ian